Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: deprecated rocksdb log configs #17009

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

glorv
Copy link
Contributor

@glorv glorv commented May 13, 2024

What is changed and how it works?

Issue Number: ref #15990

What's Changed:

The rocksdb log is replace by tikv log in #7358 about 4 years ago. After this PR, rocksdb configs `info_log_max_size`, `info_log_roll_time`, `info_log_keep_log_file_num` and `info_log_level` are no long taken effect. This PR marks these configs as deprecated and clean up related code.

Related changes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: glorv <glorvs@163.com>
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels May 13, 2024
glorv added 3 commits May 13, 2024 17:50
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/M labels May 13, 2024
@zhangjinpeng87
Copy link
Member

How about existing clusters already used rocksdb log configs upgrade to the new version?

@glorv
Copy link
Contributor Author

glorv commented May 14, 2024

How about existing clusters already used rocksdb log configs upgrade to the new version?

@zhangjinpeng87 The behavior is not changed, that is, from v5.0, rocksdb log config won't take effect anymore.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL status/LGT1 Status: PR - There is already 1 approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants