Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Uptime RPC to use in PRS #15947

Closed
wants to merge 2 commits into from
Closed

Conversation

GuptaManan100
Copy link
Member

Description

This PR starts the work for #15946.
In order to use the replica which has the highest uptime, we first need the ability to select the uptime. This PR adds a new RPC to the tablet manager client interface for this.

In the next release, when this RPC is available on all the vttablets, we can use this RPC instead of PrimaryStatus to check for the availability of all the replicas in PRS. Currently we are throwing away the results of PrimaryStatus. Instead we can call Uptime and even use the results for better choosing the primary candidate.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link
Contributor

vitess-bot bot commented May 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 15, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 15, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 15, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 52.83019% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 68.42%. Comparing base (8639de2) to head (bafb0b4).
Report is 5 commits behind head on main.

Files Patch % Lines
go/vt/mysqlctl/replication.go 0.00% 7 Missing ⚠️
...t/vtctl/grpcvtctldserver/testutil/test_tmclient.go 0.00% 7 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 4 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go 0.00% 2 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 2 Missing ⚠️
go/vt/vttablet/faketmclient/fake_client.go 0.00% 2 Missing ⚠️
go/vt/vttablet/grpctmclient/client.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15947      +/-   ##
==========================================
+ Coverage   68.41%   68.42%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      197056   197105      +49     
==========================================
+ Hits       134807   134864      +57     
+ Misses      62249    62241       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100
Copy link
Member Author

Superseded by #16022 since we can directly read the Innodb_buffer_pool_pages_data value instead of relying on the uptime as a proxy for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant