Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade web-vitals to v4 #11094

Merged
merged 7 commits into from
May 18, 2024
Merged

Upgrade web-vitals to v4 #11094

merged 7 commits into from
May 18, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented May 17, 2024

Changes

  • Updates the web-vitals package used by @astrojs/web-vitals to the newly released v4
  • This is a non-breaking upgrade for how we are using the package, but given the FID metric is now deprecated (replaced by INP), I decided to stop tracking it in @astrojs/web-vitals too.

Testing

  • Existing tests should pass
  • I also added an extra test that DB data is being inserted as expected while I was in this code

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: e25345d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 17, 2024
@delucis delucis merged commit 3c7a4fa into main May 18, 2024
14 checks passed
@delucis delucis deleted the chris/web-vitals-v4 branch May 18, 2024 14:33
@astrobot-houston astrobot-houston mentioned this pull request May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delucis @ematipico