Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added messagesTypes to JsonAbi #2332

Merged
merged 6 commits into from
May 20, 2024

Conversation

petertonysmith94
Copy link
Contributor

Closes #2331

maschad
maschad previously approved these changes May 17, 2024
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Torres-ssf
Torres-ssf previously approved these changes May 17, 2024
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the opportunity to sync the interfaces from abi-typegen?

In the future, abi-coder and abi-typegen should be merged or at least share these types.

Related:

cc @nedsalk

@petertonysmith94 petertonysmith94 dismissed stale reviews from Torres-ssf and maschad via bbe6dcc May 20, 2024 09:18
@petertonysmith94
Copy link
Contributor Author

Should we use the opportunity to sync the interfaces from abi-typegen?

In the future, abi-coder and abi-typegen should be merged or at least share these types.

Related:

cc @nedsalk

arboleya
arboleya previously approved these changes May 20, 2024
danielbate
danielbate previously approved these changes May 20, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.78%(+0%) 70.76%(+0%) 76.82%(+0%) 79.86%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit f76aa57 into master May 20, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/add-messages-types-to-json-abi branch May 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add messagesTypes for the ABI
5 participants