Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added messagesTypes to JsonAbi #2332

Merged
merged 6 commits into from
May 20, 2024
Merged

chore: added messagesTypes to JsonAbi #2332

merged 6 commits into from
May 20, 2024

Conversation

petertonysmith94
Copy link
Contributor

Closes #2331

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label May 17, 2024
@petertonysmith94 petertonysmith94 self-assigned this May 17, 2024
maschad
maschad previously approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Torres-ssf
Torres-ssf previously approved these changes May 17, 2024
View reviewed changes
arboleya
arboleya reviewed May 19, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the opportunity to sync the interfaces from abi-typegen?

In the future, abi-coder and abi-typegen should be merged or at least share these types.

Related:

cc @nedsalk

@petertonysmith94 petertonysmith94 dismissed stale reviews from Torres-ssf and maschad via bbe6dcc May 20, 2024 09:18
@petertonysmith94
Copy link
Contributor Author

Should we use the opportunity to sync the interfaces from abi-typegen?

In the future, abi-coder and abi-typegen should be merged or at least share these types.

Related:

cc @nedsalk

arboleya
arboleya previously approved these changes May 20, 2024
View reviewed changes
danielbate
danielbate previously approved these changes May 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.78%(+0%) 70.76%(+0%) 76.82%(+0%) 79.86%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit f76aa57 into master May 20, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/add-messages-types-to-json-abi branch May 20, 2024 10:57
@fuel-service-user fuel-service-user mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add messagesTypes for the ABI
5 participants
@petertonysmith94 @arboleya @danielbate @maschad @Torres-ssf