Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairtools module merge #1834

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Pairtools module merge #1834

wants to merge 42 commits into from

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 30, 2022

Continuation of #1148 as I don't have write access to push commits there.

sergpolly and others added 30 commits January 30, 2020 16:28
Walks-policy "all" creates more pair types than other policies (e.g. "uu",
which is pair obtained from sequential alignments on one side of the
read). Some of these types are a subset of rescued pairs by walks-policy
"mask". Thus, they can be colored similarly.

The colors are updated now to treat all types of walks policies and have
an interpretable color scheme for all the cases.
More pair types are added covering a broader range of pairtools output (walks-policy all)
@ewels ewels mentioned this pull request Dec 30, 2022
11 tasks
@ewels
Copy link
Member Author

ewels commented Dec 30, 2022

x-ref: #1148 (comment)

@sergpolly
Copy link
Contributor

Hi @ewels !
sorry for the delay ! I'm still alive... just slow
I've tried to do some cleanup, removed some unfinished code etc, but it looks like I'm unable to push to this branch - what should I do in this case ?

there's a lot of stuff happening with numpy (which is causing me headaches as the data structures are not easily exported into JSON)

I don't think I was able to address all of the numpy-concerns, but if you can point toward the most problematic structures - we would try to come with the solution on our side

@ewels
Copy link
Member Author

ewels commented May 21, 2023

Hi @sergpolly!

You can continue to push to your previous branch. It's a bit convoluted but we should be able to go back and forth between the two 😅 Just check out this branch locally and merge it into the branch that you were doing before, then push. This branch contains the same git history so it should work fine.

Does that make sense? I can elaborate if needed.

Phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants