-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pairtools module merge #1834
base: main
Are you sure you want to change the base?
Pairtools module merge #1834
Conversation
… into pairtools-module
Walks-policy "all" creates more pair types than other policies (e.g. "uu", which is pair obtained from sequential alignments on one side of the read). Some of these types are a subset of rescued pairs by walks-policy "mask". Thus, they can be colored similarly. The colors are updated now to treat all types of walks policies and have an interpretable color scheme for all the cases.
More pair types are added covering a broader range of pairtools output (walks-policy all)
x-ref: #1148 (comment) |
Hi @ewels !
I don't think I was able to address all of the numpy-concerns, but if you can point toward the most problematic structures - we would try to come with the solution on our side |
Hi @sergpolly! You can continue to push to your previous branch. It's a bit convoluted but we should be able to go back and forth between the two 😅 Just check out this branch locally and merge it into the branch that you were doing before, then push. This branch contains the same git history so it should work fine. Does that make sense? I can elaborate if needed. Phil |
Continuation of #1148 as I don't have write access to push commits there.