-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MosaiCatcher module #1910
base: main
Are you sure you want to change the base?
Add MosaiCatcher module #1910
Conversation
Hi @ewels ! I'm struggling to solve CI issues here with this new module, here a part of the logs:
Many thanks in advance for your help! Thomas |
Yeah I desperately need to merge another PR for DRAGEN to solve these - it's not your PR that's at fault. I'm trying to implement some new back-end stuff for MultiQC before the next release. When that's done I'll try to do a PR review sprint and get that in and sorted. Apologies for the inconvenience.. |
All fine, no worries :) Cheers! Thomas |
"hidden": False, | ||
} | ||
headers["suppl"] = { | ||
"title": "suppl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please capitalize the column names (Cell
, Mapped
, etc), replace the underscores with spaces.
Should also add "namespace": "MosaiCatcher" field into the headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the title key into the nested dictionnary or the headers dict keys?
if not log_files: | ||
log.warning("No log files found for MosaiCatcher module") | ||
else: | ||
print("Log files found:", log_files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot for the contribution!
Left some comments.
Hi @vladsavelyev ! :) Thanks for the reviewing! I wanted to filter out some columns to be included into the report but didn't find a good way to do it, do you have any tips on this? |
Hey!
Not sure I understand! Do you mean the general stats table, or the table generated by this module? All columns that you specify in |
Co-authored-by: Vlad Savelyev <vladislav.sav@gmail.com>
…into mosaicatcher
…into mosaicatcher
Seems to work! Let me know if I still need to modify something :) |
This PR adds a new module for mosaicatcher counts method. Mosaicatcher counts Strand-seq reads and classifies strand states of each chromosome in each cell using a Hidden Markov Model. The software is used as a direct first step after obtaining BAM files from Strand-Seq data.
CHANGELOG.md
has been updated--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)