Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][native] fix empty response body #18684

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Frontrider
Copy link

@Frontrider Frontrider commented May 16, 2024

To fix #13968.

The issue was that the client did not check if the response was empty before trying to read it as json, but this was only a problem if the endpoint could respond with an object and an empty response as well with the most common case being a 204 response.
This bug does not affect the async client, only the sync client.

The documentation for what I did is in a comment above the change in api.mustache.
https://github.com/telekom/openapi-generator/blob/fix/13968/modules/openapi-generator/src/main/resources/Java/libraries/native/api.mustache#L279
I included it there, because I see that there was already a failed attempt to do it in #13993, and the reason why that code could not work is not obvious.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the [technical committee]

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented May 21, 2024

thanks for the PR.

can you please PM me via Slack when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328 wing328 changed the title Fix/13968 [java][native] fix empty response body May 27, 2024
@wing328 wing328 added this to the 7.7.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Java generated client throws MismatchedInputException when response body is empty
2 participants