reinstate hive health metrics #32603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimmlerd
added
release-note/misc
This comment was marked as resolved.
This comment was marked as resolved.
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
bimmlerd
force-pushed
the
pr/bimmlerd/hive-health-metrics
branch
from
02d445d
to
b7af21f
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
bimmlerd
force-pushed
the
pr/bimmlerd/hive-health-metrics
branch
4 times, most recently
from
3281e3b
to
a285970
Compare
bimmlerd
requested review from
danehans,
dylandreimerink,
tommyp1ckles and
nebril
|
/test |
|
ah, CI found a legitimate issue - marking as draft for now, sorry for the noise |
bimmlerd
force-pushed
the
pr/bimmlerd/hive-health-metrics
branch
4 times, most recently
from
2901d35
to
4d7d063
Compare
|
/test |
bimmlerd
force-pushed
the
pr/bimmlerd/hive-health-metrics
branch
from
4d7d063
to
02140ac
Compare
|
/test |
tommyp1ckles
approved these changes
May 28, 2024
bimmlerd
force-pushed
the
pr/bimmlerd/hive-health-metrics
branch
from
02140ac
to
06ba3fa
Compare
|
/test |
Moves the healthv2 implementation to hive/health to get rid of the somewhat ugly v2 part of the pkg name, and to give some logical structure. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Pulling this bugfix in manually to ensure we don't hit race conditions after the next commit. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
With the introduction of the hive module health metric publisher in a subsequent path, a precondition of the node manager EmitStatus test will break: the test assumes the node manager to be the only writer to the status table. Without this patch, a race occurs. Since it seems likely that the set of default hive cells will grow (and that they may want to update their status too) change the test so that it no longer assumes exclusivity. It now looks specifically at its own status, and uses revisions to understand when the status changes. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Somewhere in the move from pkg/hive to cilium/hive we lost the module health metrics. Add them back in the new form of a query on the status table, and add a test. Fixes: 2311f3d (treewide: rebase on cilium/hive) Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
This ensures that logging output of the metrics job and the rest of the health subsystem are piped through the same logging mechanism. In addition, unexport what need not be exported, and avoid some amount of stuttering in "health.HealthTableName", for example. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
bimmlerd
force-pushed
the
pr/bimmlerd/hive-health-metrics
branch
from
06ba3fa
to
79e1b96
Compare
|
/test |
|
@marseel if you could take a look not only at the vendor stuff but also the mildly adapted test, I believe you've recently worked on the bg node sync stuff (in |
marseel
approved these changes
May 31, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #32020, the hive module health metrics were accidentially dropped. Reinstate them in a new form, and add a test for the functionality.