[frontend] fixed calendar button alignment in Oozie WF Submit form #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshg999
requested review from
tabraiz12,
JohanAhlen,
bjornalm,
nidhibhatg and
ananya-agarwal
|
Thanks @tarunjangid for contributing a fix! I've tagged the UI code owners for reviewing this PR. |
JohanAhlen
reviewed
May 21, 2024
| position: fixed; | ||
| } | ||
| #param-container .btn-group.open { | ||
| position: absolute !important; |
There was a problem hiding this comment.
Do you need !important here? If so perhaps some other class is more specific...
| @@ -168,6 +172,14 @@ else: | |||
| huePubSub.subscribeOnce('hide.datepicker', function () { | |||
| _el.datepicker('hide'); | |||
| }); | |||
| $(document).on("click.hideDatepicker", function (event) { | |||
There was a problem hiding this comment.
This attaches an event listener on every click ($(".calendera-link").on("click" ... above). Better to attach it on show and detach on hide.
| _el.datepicker('hide'); | ||
| } | ||
| }); | ||
| $(".calendar-link, input[type='text']").on("click.stopPropagation", function(event) { |
ananya-agarwal
requested changes
Jun 4, 2024
| @@ -218,4 +230,4 @@ else: | |||
| </div> | |||
| </div> | |||
| %endif | |||
| </%def> | |||
| </%def> | |||
There was a problem hiding this comment.
This is an unintentional change I suppose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Before:
before_changes.mov
After:
after_changes.mov
Please review Hue Contributing Guide before opening a pull request.