-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.8.5] Fix the bug of tween color property of Sprite. #16977
Conversation
ESLint issues are fixed in this PR: #16948 So I don't fix them here. |
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -17225,8 +17225,9 @@
/**
* @deprecated since v3.5.0, this is an engine private interface that will be removed in the future.
*/
_set_a_unsafe(alpha: number): Color;
+ [misc.extractPropsSymbol](): string[];
}
export function color(other: Color | string): Color;
export function color(r?: number, g?: number, b?: number, a?: number): Color;
/**
@@ -20531,8 +20532,9 @@
* @returns @en The degree. @zh 角度。
*/
export function radiansToDegrees(angle: any): number;
export const BUILTIN_CLASSID_RE: RegExp;
+ export const extractPropsSymbol: unique symbol;
export const BASE64_VALUES: number[];
}
export namespace path {
/**
|
ESLint errors were fixed at #16948 , so don't fix them here. |
I was thinking if we need to change Color implementation. Use r, g, b, a instead of _val. |
Yes, it cause some issues that we need to use bit operation in many places. |
I see. So i want to create a ticket in forum about it. I want to do it like this because it affects tween system now. |
Fixed at #17021 |
Re: #13229
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: