Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global level data_stream.dataset dashboard filter #9869

Merged
merged 15 commits into from
May 31, 2024
Merged

Add global level data_stream.dataset dashboard filter #9869

merged 15 commits into from
May 31, 2024

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented May 15, 2024 •
edited

Proposed commit message

Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.

Expect the above mentioned changes done in following selected packages to ease the review

  • Stan
  • Nats
  • Golang
  • Couchbase
  • Couchdb
  • IIS
  • Memcached
  • Zookeeper
  • InfluxDB
  • Coredns

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshot

Stan
Logs Before Logs After
stan logs overview - before stan logs overview - after
Channel Before Channel
stan channel overview - before stan channel overview - after
Nats
Metrics Before Metrics After
before_nats_metrics_dashboard after_nats_metrics_overview
Logs Before Logs After
before_nats_logs_dashboard after_nats_logs
Golang
Heap Before Heap After
golang heap - before golang heap - after
expvar Before expvar After
golang expvar - before golang expvar - after
Couchbase
xcdr Before xcdr After
couchbase xdcr overview - before couchbase xdcr overview - after
sync gateway before sync gateway after
couchbase sync gateway overview - before couchbase sync gateway overview - after
node overview before node overview after
couchbase node overview - before couchbase node overview - after
Before After
couchbase metrics overview - before couchbase metrics overview - after
Couchdb
Before After
couchdb server-before couchdb server-after
IIS
Website Overview Before Website Overview After
iis website overview-before iis website overview-after
Webserver Process Before Webserver Process After
iis webserver process overview-before iis webserver process overview-after
Webserver Overview Before Webserver Overview After
iis webserver overview-before iis webserver overview-after
Application pool overview Before Application pool overview After
iis application pool overview-before iis application pool overview-after
Access abd Error logs Before Access abd Error logs After
iis access and error logs-before iis access and error logs-after
Memcached
Stats Before Stats After
before_memcached_stats after_memcached_stats
Zookeeper
Before After
before_zookeeper_mntr after_zookeeper_mntr
InfluxDB
Status Before Status After
before_influxdb_status after_influxdb_status
Advstatus Before Advstatus After
before_influxdb_advstatus after_influxdb_advstatus
Coredns
Overview Before Overview After
coredns overview-before coredns overview-after

@milan-elastic milan-elastic self-assigned this May 15, 2024
@elasticmachine
Copy link

elasticmachine commented May 15, 2024 •
edited

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@milan-elastic milan-elastic marked this pull request as ready for review May 20, 2024 06:05
@milan-elastic milan-elastic requested a review from a team as a code owner May 20, 2024 06:05
@milan-elastic milan-elastic mentioned this pull request May 20, 2024
Open
65 tasks
harnish-elastic
harnish-elastic approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

agithomas
agithomas previously approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas dismissed their stale review May 23, 2024 06:25

Dismissing the review as more changes may be needed here.

@agithomas
Copy link
Contributor

@harnish-elastic , can you verify - if entries in validation.yml (exclude_checks) be updated as part of this change?

@harnish-elastic
Copy link
Contributor

@harnish-elastic , can you verify - if entries in validation.yml (exclude_checks) be updated as part of this change?

Okay, let me take a look at this with @milan-elastic and update if needed.

@milan-elastic
Copy link
Contributor Author

@harnish-elastic , can you verify - if entries in validation.yml (exclude_checks) be updated as part of this change?

Okay, let me take a look at this with @milan-elastic and update if needed.

Done!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @milan-elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

agithomas
agithomas approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milan-elastic milan-elastic merged commit 7775bbd into elastic:main May 31, 2024
5 checks passed
@elasticmachine
Copy link

Package coredns - 0.7.0 containing this change is available at https://epr.elastic.co/search?package=coredns

@elasticmachine
Copy link

Package couchbase - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=couchbase

@elasticmachine
Copy link

Package couchdb - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=couchdb

@elasticmachine
Copy link

Package golang - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=golang

@elasticmachine
Copy link

Package iis - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=iis

@elasticmachine
Copy link

Package influxdb - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=influxdb

@elasticmachine
Copy link

Package memcached - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=memcached

@elasticmachine
Copy link

Package nats - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=nats

@elasticmachine
Copy link

Package stan - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=stan

@elasticmachine
Copy link

Package zookeeper - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=zookeeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

Assignees

@milan-elastic milan-elastic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@milan-elastic @elasticmachine @agithomas @harnish-elastic