Improve flyte-core helm chart #5362
Conversation
Fixed flyte-core helm chart where ServiceAccounts were missing and some naming inconsistencies Signed-off-by: mvaal <mvaal@expediagroup.com>
Signed-off-by: mvaal <mvaal@expediagroup.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
| @@ -55,7 +55,7 @@ spec: | |||
| - mountPath: /var/run/credentials | |||
| name: cluster-secrets | |||
| {{- end }} | |||
| serviceAccountName: {{ .Values.cluster_resource_manager.service_account_name }} | |||
| serviceAccountName: {{ .Values.cluster_resource_manager.serviceAccount.create | ternary (include "flyteclusterresourcesync.name" .) .Values.cluster_resource_manager.service_account_name }} | |||
There was a problem hiding this comment.
Attempted to keep backwards compatibility here.
| @@ -2,7 +2,7 @@ | |||
| apiVersion: apps/v1 | |||
| kind: Deployment | |||
| metadata: | |||
| name: syncresources | |||
| name: {{ template "flyteclusterresourcesync.name" . }} | |||
There was a problem hiding this comment.
This will technically recreate the deployment when it renames, not sure if that is an issue.
| @@ -171,7 +171,7 @@ flytescheduler: | |||
| # -- Annotations for Flytescheduler pods | |||
| podAnnotations: {} | |||
| # -- Additional Flytescheduler container environment variables | |||
| podEnv: {} | |||
| podEnv: [] | |||
There was a problem hiding this comment.
These are mapped to arrays, so it gives a warning when you set them in the values.yaml.
There was a problem hiding this comment.
Ah thanks! 👍
That's my mistake and I probably missed this when I added it because we're setting podEnv values.
Signed-off-by: mvaal <mvaal@expediagroup.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5362 +/- ##
==========================================
- Coverage 61.09% 60.22% -0.88%
==========================================
Files 794 646 -148
Lines 51213 45664 -5549
==========================================
- Hits 31288 27499 -3789
+ Misses 17044 15575 -1469
+ Partials 2881 2590 -291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: mvaal <mvaal@expediagroup.com>
Fixed flyte-core helm chart where ServiceAccounts were missing, incorrect typing, and some naming inconsistencies
Tracking issue
Closes #5361
Why are the changes needed?
Removes error messages in when running the chart
Adds missing ServiceAccounts to services.
In our production clusters, we have governance that requires all Deployments must have an associated SA, this is currently preventing us from using the chart.
Adds the ability to override the service names.
Changed FlyteClusterResourceSync Deployment name
What changes were proposed in this pull request?
Helper methods refactored to allow
nameOverride.Service Accounts added and applied to Deployments.
values.yaml default values updated to array from map as that is what is expected
How was this patch tested?
Hand tested, I didn't see unit tests for the helm chart.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link