Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] flyte-core helm chart missing ServiceAccounts and chart has warning messages #5361

Open
2 tasks done
mvaalexp opened this issue May 14, 2024 · 3 comments · May be fixed by #5362
Open
2 tasks done

[BUG] flyte-core helm chart missing ServiceAccounts and chart has warning messages #5361

mvaalexp opened this issue May 14, 2024 · 3 comments · May be fixed by #5362
Assignees
Labels
bug Something isn't working helm release Tags to capture releases in flyte

Comments

@mvaalexp
Copy link

Describe the bug

flyte-core helm chart is missing some configuration functionality

  • It is missing ServiceAccounts on several Deployments
  • It has a misconfiguration in the defaults in the values.yaml causing warning messages
coalesce.go:286: warning: cannot overwrite table with non table for flyte-core.flyteagent.podEnv (map[])
  • It has naming convention inconsistencies

Expected behavior

All Deployments should have the ability to create a ServiceAccount
Helm charts should not throw errors
Should have the ability to overwrite the deployment names (same as other charts, e.g., flyteagent)

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@mvaalexp mvaalexp added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels May 14, 2024
Copy link

welcome bot commented May 14, 2024

Thank you for opening your first issue here! 🛠

Copy link

runllm bot commented May 14, 2024

To address the issues with the flyte-core Helm chart, you can modify the values.yaml file to ensure ServiceAccounts are created for all necessary deployments and correct any misconfigurations. Here are the steps:

  1. ServiceAccounts Configuration: Ensure that each deployment has the serviceAccount section properly configured in the values.yaml file. For example, for flyteadmin:
flyteadmin:
  serviceAccount:
    create: true
    name: flyteadmin
  1. Fixing Warnings: Address the warning messages by ensuring that the values.yaml file does not have conflicting types for the same key. For example, ensure flyteagent.podEnv is correctly defined as a table if it is being overwritten.

  2. Naming Conventions: Ensure consistent naming conventions across the Helm chart by standardizing the names used in the values.yaml file and the templates.

Would you like more detailed steps or code snippets for these configurations?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@mvaalexp mvaalexp linked a pull request May 14, 2024 that will close this issue
3 tasks
@mvaalexp
Copy link
Author

I have drafted proposed changes here:
#5362

@eapolinario eapolinario added helm release Tags to capture releases in flyte and removed untriaged This issues has not yet been looked at by the Maintainers labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm release Tags to capture releases in flyte
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants