Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for step 6 of todo project #54625

Closed
jdwilkin4 opened this issue May 2, 2024 · 5 comments · Fixed by #54626
Closed

Fix tests for step 6 of todo project #54625

jdwilkin4 opened this issue May 2, 2024 · 5 comments · Fixed by #54626
Labels
help wanted Open for all. You do not need permission to work on these. new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@jdwilkin4
Copy link
Contributor

Describe the Issue

It looks like an update was made a few weeks ago to the tests for this step.
But it doesn't look like the tests account for valid answers like this

openTaskFormBtn.addEventListener('click', () => {
  taskForm.classList.toggle('hidden')
});

camper was struggling with this on the forum here
https://forum.freecodecamp.org/t/learn-localstorage-by-building-a-todo-app-step-6/688284

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-localstorage-by-building-a-todo-app/step-6

Your code

see explanation above

Expected behavior

see explanation above

Screenshots

No response

System

  • Device: [e.g. iPhone 6, Laptop]
  • OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]

Additional context

No response
@jdwilkin4 jdwilkin4 added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. new javascript course These are for issues dealing with the new JS curriculum labels May 2, 2024
@jdwilkin4 jdwilkin4 changed the title Fix tests for allow for multiple correct answers for step 6 of todo project Fix tests for step 6 of todo project May 2, 2024
@Deep512 Deep512 mentioned this issue May 2, 2024
Merged
4 tasks
@Deep512
Copy link
Contributor

Deep512 commented May 2, 2024 •
edited

Have raised a PR for this. Please review @jdwilkin4 @naomi-lgbt

@chaudharydivya199
Copy link

chaudharydivya199 commented May 3, 2024 •
edited

can i work on this @jdwilkin4 ?

@Deep512
Copy link
Contributor

Deep512 commented May 3, 2024 •
edited

@chaudharydivya199 don't require permissions from the code owners to work on issues marked with help wanted.
They are open for all (just there shouldn't be any PR raised to resolve that).

@Supravisor Supravisor mentioned this issue May 4, 2024
Closed
4 tasks
@jdwilkin4
Copy link
Contributor Author

@Deep512

Thank you for your interest in working on this.
But it is best not to @ members of the PR team when you create a PR.
The team will get to all PR's when they have time.
Thanks 👍

@jdwilkin4
Copy link
Contributor Author

@chaudharydivya199

You can read more about the contributing process for freeCodeCamp in the docs here
https://contribute.freecodecamp.org/#/index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these. new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Milestone
No milestone
3 participants
@Deep512 @chaudharydivya199 @jdwilkin4