New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(curriculum): fix tests for step 6 of the todo project #54626
Conversation
@ilenia-magoni @gikf Please review the PR |
We realize you're looking to get help as soon as possible. Rather than pinging someone directly, which can be considered rude, would you mind joining our Discord and asking your question there? Someone might be more readily available to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I wonder if we should just click the button in the tests and then assert the modal has the class?
That sure is a valid alternative solution. However, considering that the regex testing was already implemented in the codebase, I chose to address the issue by updating the regex to handle the edge case. Let me know if you think we should still update the test logic. |
Please stop pinging people to require a review, it's the second time you are being asked to avoid doing that please |
I am extremely sorry @ilenia-magoni, didn't intend to cause any inconvenience. Wasn't aware of the process of review here and might have missed the bot message. |
...and-data-structures-22/learn-localstorage-by-building-a-todo-app/64e4e78a7ea4a168de4e6a38.md
Outdated
Show resolved
Hide resolved
…a-structures-22/learn-localstorage-by-building-a-todo-app/64e4e78a7ea4a168de4e6a38.md Co-authored-by: Jessica Wilkins <67210629+jdwilkin4@users.noreply.github.com>
Checklist:
main
branch of freeCodeCamp.Closes #54625
Updated the regex to handle the only unhandled answer:
Issue addressed in the forum
Post fix screenshot: