Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add tests for the progress reset flow #54614

Merged
merged 6 commits into from May 13, 2024

Conversation

huyenltnguyen
Copy link
Member

@huyenltnguyen huyenltnguyen commented May 2, 2024

Checklist:

When I was working on #54542, I found that we don't have tests for the progress reset flow. But adding tests for it requires some code cleanup so I decided to split the work to a separate PR.

This PR:

  • Renames the existing reset-modal.spec.ts to challenge-reset-modal.spec.ts
    • We have two reset modals, both are namedreset-modal.tsx, but one is for resetting the code of a challenge and one is for resetting all progress
  • Adds progress-reset-modal.spec.ts
  • Removes the Cypress test for the progress reset modal
  • Removes some assertions from a test in settings.spec.ts since they are redundant

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 2, 2024
e2e/settings.spec.ts Show resolved Hide resolved
e2e/settings.spec.ts Show resolved Hide resolved
@huyenltnguyen huyenltnguyen marked this pull request as ready for review May 3, 2024 09:37
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner May 3, 2024 09:37
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@huyenltnguyen huyenltnguyen mentioned this pull request May 6, 2024
61 tasks
@huyenltnguyen huyenltnguyen added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label May 10, 2024
@huyenltnguyen huyenltnguyen merged commit 6c3e1ce into freeCodeCamp:main May 13, 2024
22 checks passed
@huyenltnguyen huyenltnguyen deleted the test/progress-reset branch May 13, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: merge conflict To be applied to PR's that have a merge conflict and need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants