New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(curriculum): prevent passing in case of <img> element not closed #54644
Conversation
...-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md
Outdated
Show resolved
Hide resolved
...-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md
Outdated
Show resolved
Hide resolved
…n-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
…n-html-by-building-a-cat-photo-app/5dc24073f86c76b9248c6ebb.md Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just realized that it doesn't take into account single quotes. Should we allow them? @huyenltnguyen
@Dario-DC That's a good catch! I was focusing on the @zxc-w Would you mind updating the regex to allow single quotes? (It's okay if you don't want to make further changes, we are happy to help with that, since this is a slight scope creep 🙂) |
@huyenltnguyen sure, I was just waiting to see if I should update it or not. |
Checklist:
main
branch of freeCodeCamp.Closes #54642