Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): prevent passing in case of <img> element not closed #54644

Merged
merged 5 commits into from
May 6, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ Although you have set the `img` element's `src` to the correct URL, it is recomm
assert(!/\<img\s+src\s*=\s*https:\/\/cdn\.freecodecamp\.org\/curriculum\/cat-photo-app\/relaxing-cat\.jpg/.test(code));
```

Your `img` element should be closed either with `>` or `/>`
zxc-w marked this conversation as resolved.
Show resolved Hide resolved

```js
assert(/<img\s+src\s*=\s*"https:\/\/cdn\.freecodecamp\.org\/curriculum\/cat-photo-app\/relaxing-cat\.jpg"\s*(?:\/?>)/.test(code));
zxc-w marked this conversation as resolved.
Show resolved Hide resolved
```

# --seed--

## --seed-contents--
Expand Down