Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add book 1 translation into Ukrainian #1720

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Conversation

AMashoshyna
Copy link
Collaborator

@AMashoshyna AMashoshyna commented Jan 6, 2021

This PR adds book 1 translation into Ukrainian by @Croftyland and myself. Book 2 is in progress.
related issue: #1719

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).

Specifically quoting these guidelines regarding typos:

Typos?

Please don't worry about minor text typos. These will almost certainly be caught during the editing process.

If you're going to submit a PR for typo fixes, please be measured in doing so by collecting several small changes into a single PR (in separate commits). Or, just don't even worry about them for now, because we'll get to them later. I promise.


Please type "I already searched for this issue":
I already searched for this issue

Edition: (pull requests not accepted for previous editions)
Second edition

Book Title:
Getting started

Chapter:

Section Title:

Topic:

Copy link
Owner

@getify getify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could we also translate the main root README so that when Ukranian readers land on this repository, they see all the welcome text in the expected language?

@AMashoshyna
Copy link
Collaborator Author

Sure! Working on it.

@getify getify merged commit f6a9051 into getify:2ed-uk Jan 7, 2021
@getify
Copy link
Owner

getify commented Jan 7, 2021

Great, thanks so much for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants