add book 1 translation into Ukrainian #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getify
requested changes
Jan 6, 2021
Owner
getify
left a comment
getify
left a comment
There was a problem hiding this comment.
LGTM.
Could we also translate the main root README so that when Ukranian readers land on this repository, they see all the welcome text in the expected language?
Collaborator
Author
|
Sure! Working on it. |
getify
approved these changes
Jan 7, 2021
Owner
|
Great, thanks so much for your work! |
petekip
pushed a commit
to petekip/You-Dont-Know-JS
that referenced
this pull request
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds book 1 translation into Ukrainian by @Croftyland and myself. Book 2 is in progress.
related issue: #1719
Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).
Specifically quoting these guidelines regarding typos:
Please type "I already searched for this issue":
I already searched for this issue
Edition: (pull requests not accepted for previous editions)
Second edition
Book Title:
Getting started
Chapter:
Section Title:
Topic: