removed simplejson

[AndrewChubatiuk]

What type of PR is this?

Removed unneeded simplejson dependency

• Refactor
• Feature
• Bug Fix
• New Query Runner (Data Source)
• New Alert Destination
• Other

[masayuki038]

Thanks for separating this update from #6671.

I think this PR is related to #6218.
@konnectr @justinclift Could you review this?

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3c2c278) 63.30% compared to head (7bd2e00) 63.30%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6685   +/-   ##
=======================================
  Coverage   63.30%   63.30%           
=======================================
  Files         162      162           
  Lines       13322    13322           
  Branches     1820     1820           
=======================================
  Hits         8434     8434           
  Misses       4599     4599           
  Partials      289      289           

Files	Coverage Δ
redash/authentication/jwt_auth.py	77.35% <100.00%> (ø)
redash/utils/__init__.py	72.51% <100.00%> (ø)
redash/cli/__init__.py	59.61% <50.00%> (ø)
redash/handlers/webpack.py	95.00% <50.00%> (ø)
redash/query_runner/arango.py	60.46% <0.00%> (ø)
redash/query_runner/athena.py	50.81% <0.00%> (ø)
redash/query_runner/big_query.py	23.68% <0.00%> (ø)
redash/query_runner/pg.py	41.91% <0.00%> (ø)

[justinclift]

@guidopetri Any interest in taking a look at this? 😄

[guidopetri]

Sorry, I don't understand why we're changing to the JSON library. The original thread here doesn't make sense to me - the question of "why are we replacing this with the standard json library?" wasn't answered. Is the standard json library faster?

[AndrewChubatiuk]

@guidopetri it was removed in flask 2.0 by default and yes, simplejson is slower.

Results

loads (large obj)

json 0.333s
simplejson 0.351s

dumps (large obj)

json 0.364s
simplejson 0.409s

loads (small objs)

json 0.359s
simplejson 0.438s

dumps (small objs)

json 0.542s
simplejson 0.944s

[guidopetri]

Got it, thanks!

[justinclift]

Looks like this PR just needs it's dependencies updated by poetry (again?), then we can merge it. 😄

[AndrewChubatiuk]

Looks like this PR just needs it's dependencies updated by poetry (again?), then we can merge it. 😄

Done

[justinclift]

Cool, lets get this merged. 😄

[justinclift]

@AndrewChubatiuk Merged, thanks for getting this all done. 😄