Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NUnit from 3.14.0 to 4.1.0 in /src #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2024

Bumps NUnit from 3.14.0 to 4.1.0.

Release notes

Sourced from NUnit's releases.

NUnit 4.1.0

See release notes

NUnit 4.0.1

Patch release to fix windows targets

See release notes and See migration guide

NUnit 4.0.0

See release notes and See migration guide

NUnit 4.0.0-beta.1

See release notes and information

Changelog

Sourced from NUnit's changelog.

For further changes, see release notes


NUnit 4.0.0 - November 26, 2023

All changes, see release notes

NUnit 4.0.0-beta.1 - October 8, 2023

This release is the first beta release of NUnit 4.0. All changes, see release notes

NUnit 3.13.2 - April 27, 2021

This release fixes a new issue with the FixtureLifeCycle attribute where IDisposable test fixtures were not being disposed properly. As always, @​gleb-osokin has been a great help with this new feature.

It also fixes a long-standing performance issue with CollectionAssert.AreEquivalent and the CollectionEquivalentConstraint when comparing large collections. The deep comparison that NUnit performs on the two collections will always have a worst case bound of O(n^2) but we have optimized it so that the majority of use cases will be closer to O(n).

We've also made significant optimizations to the OR filters for selecting tests using their full name. This dramatically improves test performance for large code bases that use dotnet test. Thanks to @​pakrym for his help with this.

Issues Resolved

  • 2799 CollectionAssert.AreEquivalent is extremely slow
  • 3589 File headers, copyrights, and licenses
  • 3773 IDisposable not working with InstancePerTestCase
  • 3779 Obsolete AreEqual methods with nullable numeric arguments for 3.13
  • 3784 Build the v3.13-dev branch
  • 3786 NUnit with dotnet test results in O(n^2) filtering complexity
  • 3810 Enable deterministic build
  • 3818 AppVeyor failing to build v3.13-dev branch PRs
  • 3832 Deploy v3.13-dev branch builds to MyGet

NUnit 3.13.1 - January 31, 2021

This release addresses several misses with the new FixtureLifeCycle attribute, switches to using SourceLink and NuGet snupkg packages for debugging into NUnit from your unit tests. It also addresses issues with the time format of ignored and explicit tests in the test results file.

Issues Resolved

  • 2339 Wrong date format in Ignored TestFixtures
  • 3715 FixtureLifeCycle(LifeCycle.InstancePerTestCase) Not working with TestFixtureSource
  • 3716 Assembly level FixtureLifeCycle(LifeCycle.InstancePerTestCase) doesn't work
  • 3724 Test start and end time should end with Z
  • 3726 Assert EqualTo().Within().Seconds does not work with DateTimes in NUnit 3.13
  • 3729 AppVeyor builds failing
  • 3736 AreEqual.Within throws on failure with non-numeric types
  • 3743 Parametrized tests do not respect FixtureLifeCycle.InstancePerTestCase
  • 3745 After upgrading to NUnit 3.13.0 the debugger enters NUnit code despite having checked "Enable Just My Code"

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner April 25, 2024 16:05
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 25, 2024
@dependabot dependabot bot requested review from jessicaliu100, a team and ArinGhazarian and removed request for a team April 25, 2024 16:05
Copy link

github-actions bot commented Apr 25, 2024

Unit Test Results

0 tests   - 42   0 ✅  - 42   0s ⏱️ ±0s
0 suites  -  1   0 💤 ± 0 
0 files    -  1   0 ❌ ± 0 

Results for commit 9fb557e. ± Comparison against base commit 0577560.

♻️ This comment has been updated with latest results.

@dependabot dependabot bot force-pushed the dependabot/nuget/src/NUnit-4.1.0 branch from 190f900 to 1af7e83 Compare April 25, 2024 16:07
@begonaguereca
Copy link
Collaborator

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/nuget/src/NUnit-4.1.0 branch 2 times, most recently from 41c8996 to 64c024c Compare April 25, 2024 23:10
Bumps [NUnit](https://github.com/nunit/nunit) from 3.14.0 to 4.1.0.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/master/CHANGES.md)
- [Commits](nunit/nunit@v3.14.0...4.1.0)

---
updated-dependencies:
- dependency-name: NUnit
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/src/NUnit-4.1.0 branch from 64c024c to 9fb557e Compare April 25, 2024 23:14
@ArinGhazarian
Copy link
Collaborator

This NUnit version introduces a breaking change (related SO trhead). We have the following options:

  1. Fix the issues which is relatively easy considering that there aren't too many tests.
  2. Skip major updates and only apply minor security patches, etc.
  3. We might also want to swap nunit with xunit to be in sync with gh-gei so in case of any further breaking changes we can at least expect similar process for fixing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants