Fix a bug related to not clearing the dataset correctly for formulas #10983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Launch the local version of documentation by running: npm run docs:review 08414d1fb6ce9da73ae9790df94aa54f106d9d2b |
jansiegel
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR fixes a bug related to not clearing the dataset correctly when Formulas is enabled. The unordered indexes passed to the HF API caused the issue.
How has this been tested?
I tested the changes locally and I covered the fix with tests.
Types of changes
Related issue(s):
Affected project(s):
handsontableChecklist: