Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing predefined menu item key types for menu config #10984

Merged
merged 3 commits into from
May 20, 2024

Conversation

budnix
Copy link
Member

@budnix budnix commented May 17, 2024

Context

The PR improves typings for the ContextMenu plugin.

How has this been tested?

I tested the changes locally and I covered the fix with an updated test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1903

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this May 17, 2024
@budnix budnix marked this pull request as ready for review May 17, 2024 10:56
@budnix budnix requested a review from jansiegel May 17, 2024 10:56
Copy link

Launch the local version of documentation by running:

npm run docs:review 6d2f1672938873873f9ab0463cb382403212fa79

@budnix budnix merged commit 53e22be into develop May 20, 2024
23 checks passed
@budnix budnix deleted the feature/dev-issue-1903 branch May 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants