Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3103 added showButton option to GeoLocate control. #4134

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

smellman
Copy link
Contributor

#3103 added showButton option to GeoLocate control.

1ec6596717587fab65ea5ab2467e557b

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.82%. Comparing base (82ca72a) to head (092b515).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4134      +/-   ##
==========================================
+ Coverage   86.70%   86.82%   +0.11%     
==========================================
  Files         242      242              
  Lines       33044    33049       +5     
  Branches     2001     2132     +131     
==========================================
+ Hits        28652    28695      +43     
+ Misses       3432     3401      -31     
+ Partials      960      953       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Member

HarelM commented May 18, 2024

I have outlined what I believe should be the right solution - refactoring the state management logic out so that it can be reused with other UI controls.
Addind a display:none can be done using css or JavaScript outside this codebase.

@smellman
Copy link
Contributor Author

I fix to use css.

@HarelM
Copy link
Member

HarelM commented May 20, 2024

As I wrote, CSS can be used without any chance to this library code.
Moving the state management and location listening to a different class is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants