feat: add a settings per projects and per tables for the pagination and number of rows shown #8360
Conversation
|
|
WalkthroughWalkthroughThe recent changes focus on enhancing pagination controls throughout the UI and SDK. These updates introduce new features like custom pagination limits, support for Databricks in the API, and additional interfaces for diverse data representations. The modifications aim to improve user interaction and broaden compatibility with various data sources, while also extending the test suite to cover the new pagination functionalities. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (2)
Files selected for processing (8)
Files skipped from review as they are similar to previous changes (7)
Additional comments not posted (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Out of diff range and nitpick comments (1)
packages/nc-gui/components/project/AllTables.vue (1)
168-174: Add an accessible label to the button for setting pagination limits to improve accessibility for users who rely on screen readers.
| | 'sqlite3' | ||
| | 'databricks'; |
There was a problem hiding this comment.
Addition of 'databricks' to the source types is correct. Consider refactoring to avoid defining the same union type in multiple places.
| | 'sqlite3' | ||
| | 'databricks'; |
There was a problem hiding this comment.
Addition of 'databricks' to the client types is correct. Consider refactoring to avoid defining the same union type in multiple places.
| if (!val) { | ||
| val = 25 |
There was a problem hiding this comment.
Consider using a constant for the default page size instead of hardcoding '25' in multiple places. This would make the code cleaner and easier to maintain if the default size needs to be changed in the future.
| // reset to default value if user input is empty | ||
| if (!val) { | ||
| val = 25 | ||
| } |
There was a problem hiding this comment.
Consider using a constant for the default page size instead of hardcoding '25' in multiple places. This would make the code cleaner and easier to maintain if the default size needs to be changed in the future.
…ches default options
kateyslee
force-pushed
the
base-frontend
branch
from
d92bed2
to
2a5043f
Compare
|
@gercokim custom pagination is now supported in development mode already & will be included in our next OSS release |
|
@dstala is custom pagination across base/projects and for selected tables already supported? |
|
custom pagination would be available in limited page size options (25, 50, 75, 100). this will be configuration at browser level- and will be applied to all base & projects for that user on that browser. |
|
Closing this. Pagination limit configuration available in new release. Reopen this PR if you wish to add more details to the submitted feature. |
Change Summary
Addresses #7872
Change type
Test/ Verification
Wrote a playwright test for the tabel level pagination limit setting to ensure that changing the pagination limit via the new setting changes the number of rows on a page for a table.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of
Summary by CodeRabbit
.gitignoreto excludevenvdirectory for cleaner project management.