feat: add a settings per projects and per tables for the pagination and number of rows shown #8360
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,3 +96,4 @@ test_noco.db | |
| httpbin | ||
| .run/test-debug.run.xml | ||
|
|
||
| venv | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| <script setup lang="ts"> | ||
| import { | ||
| Form, | ||
| TabType, | ||
| computed, | ||
| nextTick, | ||
| onMounted, | ||
| ref, | ||
| useBase, | ||
| useTableNew, | ||
| useTablesStore, | ||
| useTabs, | ||
| useVModel, | ||
| validateTableName, | ||
| } from '#imports' | ||
|
|
||
| import NcTooltip from '~/components/nc/Tooltip.vue' | ||
| import { useGlobal } from '#imports' | ||
|
|
||
| const props = defineProps<{ | ||
| modelValue: boolean | ||
| sourceId: string | ||
| baseId: string | ||
| current: number | ||
| total: number | ||
| pageSize: number | ||
| mode?: 'simple' | 'full' | ||
| prevPageTooltip?: string | ||
| nextPageTooltip?: string | ||
| firstPageTooltip?: string | ||
| lastPageTooltip?: string | ||
| showSizeChanger?: boolean | ||
| }>() | ||
|
|
||
| // const emit = defineEmits(['update:modelValue', 'create']) | ||
| const emits = defineEmits(['update:current', 'update:pageSize']) | ||
|
|
||
| const dialogShow = useVModel(props, 'modelValue', emits) | ||
|
|
||
| const { total, showSizeChanger } = toRefs(props) | ||
|
|
||
| const current = useVModel(props, 'current', emits) | ||
|
|
||
| const pageSize = useVModel(props, 'pageSize', emits) | ||
|
|
||
| const { gridViewPageSize, setGridViewPageSize } = useGlobal() | ||
|
|
||
|
|
||
|
|
||
| const localPageSize = computed({ | ||
| get: () => { | ||
| return gridViewPageSize.value | ||
| }, | ||
| set: (val) => { | ||
| // reset to default value if user input is empty | ||
| if (!val) { | ||
| val = 25 | ||
| } | ||
| setGridViewPageSize(val) | ||
| pageSize.value = val | ||
| }, | ||
| }) | ||
|
|
||
| const pageSizeOptions = [ | ||
| { | ||
| value: 25, | ||
| label: '25 / page', | ||
| }, | ||
| { | ||
| value: 50, | ||
| label: '50 / page', | ||
| }, | ||
| { | ||
| value: 75, | ||
| label: '75 / page', | ||
| }, | ||
| { | ||
| value: 100, | ||
| label: '100 / page', | ||
| }, | ||
| ] | ||
|
|
||
| const pageSizeDefaults = pageSizeOptions.map((item) => item.value) | ||
|
|
||
|
|
||
| const customPageValue = computed({ | ||
| get: () => { | ||
| return "" | ||
| }, | ||
| set: (val) => { | ||
| localPageSize.value = val | ||
| }, | ||
| }) | ||
|
|
||
| const customPageOption = computed({ | ||
| get: () => { | ||
| if (pageSizeDefaults.includes(localPageSize.value)) { | ||
| return localPageSize.value | ||
| } | ||
| return localPageSize.value.toString().concat(" / page") | ||
| }, | ||
| set: (val) => { | ||
| localPageSize.value = val | ||
| } | ||
| }) | ||
|
|
||
| const pageSizeRef = ref() | ||
|
|
||
| const pageSizeDropdownVisibleChange = (value: boolean) => { | ||
| if (!value && pageSizeRef.value) { | ||
| pageSizeRef.value?.blur() | ||
| } | ||
| } | ||
|
|
||
| </script> | ||
|
|
||
| <template> | ||
| <NcModal v-model:visible="dialogShow" :header="$t('labels.modifyPaginationLimit')" size="small" @keydown.esc="dialogShow = false"> | ||
| <template #header> | ||
| <div class="flex flex-row items-center gap-x-2"> | ||
| {{ $t('labels.modifyPaginationLimit') }} | ||
| </div> | ||
| </template> | ||
| <div class="nc-pagination flex flex-row items-center gap-x-2"> | ||
| <a-select ref="pageSizeRef" v-model:value="customPageOption" class="!min-w-[110px]" :options="pageSizeOptions" | ||
| size="small" dropdown-class-name="nc-pagination-dropdown" | ||
| @dropdown-visible-change="pageSizeDropdownVisibleChange"> | ||
| <template #suffixIcon> | ||
| <GeneralIcon icon="arrowDown" class="text-gray-500 nc-select-page-size-expand-btn" /> | ||
| </template> | ||
| </a-select> | ||
| <!-- Input and Button for entering a value --> | ||
| <input v-model.lazy="customPageValue" type="number" placeholder="Set custom page size" size="small" /> | ||
|
|
||
| </div> | ||
| </NcModal> | ||
| </template> | ||
|
|
||
| <style lang="scss" scoped> | ||
| :deep(.ant-select-selector) { | ||
| @apply !border-gray-200 !rounded-lg !h-[25px]; | ||
| } | ||
|
|
||
| :deep(.nc-button:not(:disabled)) { | ||
| .nc-pagination-icon { | ||
| @apply !text-gray-500; | ||
| } | ||
| } | ||
| </style> | ||
|
|
||
| <style lang="scss"> | ||
| .nc-pagination-dropdown { | ||
| @apply !rounded-lg; | ||
| } | ||
| </style> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a constant for the default page size instead of hardcoding '25' in multiple places. This would make the code cleaner and easier to maintain if the default size needs to be changed in the future.