New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add projections to keep join keys as col=col
#52989
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52989 +/- ##
=================================================
- Coverage 72.3746% 55.9319% -16.4428%
=================================================
Files 1482 1614 +132
Lines 428762 605243 +176481
=================================================
+ Hits 310315 338524 +28209
- Misses 99149 243441 +144292
- Partials 19298 23278 +3980
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rightPlan, lCol = s.injectExpr(rightPlan, newSf.GetArgs()[1]) | ||
} | ||
leftNode, rightNode = leftPlan, rightPlan | ||
newSf = expression.NewFunctionInternal(s.ctx.GetExprCtx(), ast.EQ, edge.GetType(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is SF means ? Scalar Function ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, elsa0520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/cherry-pick release-8.1 |
@qw4990: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #46556
Problem Summary: planner: add projections to keep join keys as
col=col
What changed and how does it work?
In some cases, after creating new EQ function, the 2 args might not be column anymore, which breaks the assumption that join eq keys must be
col=col
, to handle this, inject 2 projections.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.