Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add projections to keep join keys as col=col (#52989) #53326

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52989

What problem does this PR solve?

Issue Number: close #46556

Problem Summary: planner: add projections to keep join keys as col=col

What changed and how does it work?

In some cases, after creating new EQ function, the 2 args might not be column anymore, which breaks the assumption that join eq keys must be col=col, to handle this, inject 2 projections.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 16, 2024
Copy link

ti-chi-bot bot commented May 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 06:16:21.132079428 +0000 UTC m=+1720334.889215000: ☑️ agreed by qw4990.
  • 2024-05-16 06:20:49.856405523 +0000 UTC m=+1720603.613541139: ☑️ agreed by elsa0520.

Copy link

ti-chi-bot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, hawkingrei, qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [elsa0520,hawkingrei,qw4990,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-8.1@ff5eb17). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53326   +/-   ##
================================================
  Coverage               ?   71.1706%           
================================================
  Files                  ?       1465           
  Lines                  ?     421390           
  Branches               ?          0           
================================================
  Hits                   ?     299906           
  Misses                 ?     101004           
  Partials               ?      20480           
Flag Coverage Δ
unit 71.1706% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9738% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 607e297 into pingcap:release-8.1 May 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.1 approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug-fix This PR fixes a bug. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants