ESM script base class #6367
Open
ESM script base class #6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklundin
requested review from
Maksims,
willeastcott,
slimbuck,
kpal81xd and
mvaligursky
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
What would be the impact to users in terms of migrations or API changes? |
|
…PU (#6394) * Support for Picker on WebGPU * Gizmos example on webgpu * USDZ / GLTF exporter supports exposing of compressed textures on WebGPU * tiny comment update --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
* SSAO engine example * lint * draco + texture resize: 17MB -> 6MB --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
* [BREAKING] Removed backwards compatibility for few functions * lint --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
* treeshake smallest enabled * ignore playcanvas PCUI from being treeshaken * treeshake ignore only pcui * added device type constants directly (no playcanvas dependency) * format rollup * word wrap fix * Updated PCUI * removed PCUI aliasing
…6593) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
* New texture formats: R8 and RG8 * Apply suggestions from code review Co-authored-by: Will Eastcott <will@playcanvas.com> * deprecate the old constants --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: Will Eastcott <will@playcanvas.com>
* separated out grid code * split out selector and disabled deselection on orbiting * added type for observer set callback * fixed example page
* cleaned up ts and js config; adds debug and profiler to exports * set module resolution to node
* docs update * Update README.md --------- Co-authored-by: Will Eastcott <willeastcott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Script Base class
This PR adds a new base class
Scriptto replace the currentScriptTypeclass which is incompatible with ESM class syntax.The
Scriptclass extracts a small subset of features fromScriptTypeand keeps anything related toScriptAttributesinScriptType.ScriptTypenow inherits fromScript. This update minimizes the code changes required in the component system.Files Changes
script.jsrenamed toscript-create.jsscript.jscontainsScriptbase classscript-type.jscontains legacyScriptTypeclassAPI Changes
ScriptAttributes.rawToValueis now exposed as a utility. This will also be used by the launcher pageScriptRegistry.addSchema/getSchema- This stores a map of the the attribute schema<scriptName, schema>Tests
Passes the ScriptType tests in
npm run test:karmaI confirm I have read the contributing guidelines and signed the Contributor License Agreement.