Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tooltip index is decided through selector, not reading DOM #4543

Merged
merged 4 commits into from
May 19, 2024

Conversation

PavelVanecek
Copy link
Collaborator

Description

This removed some of the test failures, will continue in next PR.

Related Issue

#3717

Motivation and Context

Remove direct DOM access

How Has This Been Tested?

npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (74fa2a3) to head (eb67702).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x    #4543      +/-   ##
==========================================
+ Coverage   95.58%   95.59%   +0.01%     
==========================================
  Files         116      116              
  Lines       22365    22430      +65     
  Branches     3073     3080       +7     
==========================================
+ Hits        21378    21443      +65     
  Misses        981      981              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ckifer ckifer merged commit 49dd104 into recharts:3.x May 19, 2024
5 checks passed
@PavelVanecek PavelVanecek deleted the defaultIndex-in-state branch May 19, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants