VRF-1096: Remove onlyOwner modifier from test consumers for when maki… #13228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
|
I see you updated files related to
|
… into chore/VRF-1096-remove-onlyOwner
|
Is this contract deployed together in the universe script as a test consumer? If so, then it's possible for others to request random words when we test on mainnet right? |
ibrajer
approved these changes
May 17, 2024
@leeyikjiun yes, we deploy this consumer (here) but we stopped deploying to Mainnet via universe script, now its done via gauntlet |
leeyikjiun
approved these changes
May 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2024
#13228) * VRF-1096: Remove onlyOwner modifier from test consumers for when making rand requests * Update gethwrappers * TT-1172: adding wrapper contract changes --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
DeividasK
added a commit
that referenced
this pull request
May 27, 2024
commit 9b8e252 Author: ilija42 <57732589+ilija42@users.noreply.github.com> Date: Mon May 27 11:58:43 2024 +0200 Relayer ContractReader( chain reader) constructor (#13274) * Implement NewChainReader method for evm Relayer * Update relayer refs * Update relayer refs commit 4fce666 Author: Rens Rooimans <github@rensrooimans.nl> Date: Mon May 27 11:43:18 2024 +0200 bump typescript-eslint and minor npm dependencies (#13270) * bump typescript-eslint * bump patches * bump eslint again * bump changesets commit 920ce31 Author: Sneha Agnihotri <180277+snehaagni@users.noreply.github.com> Date: Fri May 24 15:57:48 2024 -0700 @chainlink.contracts release v1.1.1 (#13039) * @chainlink/contracts - Update changelog for contracts/1.1.1 beta creation * @chainlink/contracts - update 1.1.1 with latest develop * chore: increase solhint max warnings to 2 (#13234) * @chainlink/contracts - Finalizing date for 1.1.1 in changelog --------- Co-authored-by: Erik Burton <erikburt@users.noreply.github.com> commit 3af83ed Author: Mateusz Sekara <mateusz.sekara@smartcontract.com> Date: Fri May 24 19:37:23 2024 +0200 Index only the fifth word to reduce the db size overhead (#13315) Co-authored-by: Domino Valdano <domino.valdano@smartcontract.com> commit 6bd866a Author: Aaron Lu <50029043+aalu1418@users.noreply.github.com> Date: Fri May 24 07:54:02 2024 -0600 replace multierr.Errors with nested error flattening (#13310) * unwrap nested errors - less hacky * bump solana to merged commit commit 4190c79 Author: Anirudh Warrier <12178754+anirudhwarrier@users.noreply.github.com> Date: Fri May 24 18:56:07 2024 +0530 fix default automation test config (#13314) * fix default automation test config * fix load test cleanup commit 1c51553 Author: Anirudh Warrier <12178754+anirudhwarrier@users.noreply.github.com> Date: Fri May 24 10:38:34 2024 +0530 Improve Automation Load Test (#13313) * bump load test DB size to 20G * add RemoveNamespace test config commit 4718aa7 Author: Augustus <14297860+augustbleeds@users.noreply.github.com> Date: Thu May 23 17:06:37 2024 -0400 BCI-1426: Add GasPriceSubunits Data Source Pipeline (#13200) * initial * incorporate gasPriceSubunits data source * update deps * add in data source * comment * update plugin config * add changeset * update chainlink-common & chainlink-feeds * lint fixes * lint --------- Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com> commit c7a6356 Author: Friedemann Fürst <59653747+friedemannf@users.noreply.github.com> Date: Thu May 23 22:02:03 2024 +0200 Decouple ChainType from config string [SHIP-2001] (#13272) * fix: Decouple ChainType from config string * fix: receiver name and failing test * test: enhance config test to test for xdai specifically * refactor: directly unmarshal into ChainType * fix: validation * test: fix TestDoc/EVM * test: add xdai to warnings.xtar commit e2bedae Author: Aaron Lu <50029043+aalu1418@users.noreply.github.com> Date: Thu May 23 13:00:55 2024 -0600 bump solana + cleanup types (#13253) * bump solana + cleanup types * bump solana with multierr delimiter * fix type * bump solana + fix parameters * bump solana * add more unwrapping * bump solana * update e2e test workflow * try without download * add gauntlet build * bump solana commit c15e9e5 Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Thu May 23 19:37:33 2024 +0300 VRF-1106: Add "vrf_job_simulation_block" to default.toml (#13296) commit 2380c41 Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Thu May 23 19:36:25 2024 +0300 VRF-1112: remove unnecessary check from TestVRFv2PlusReplayAfterTimeout test to fix the test (#13306) commit 203a95e Author: Bartek Tofel <bartek.tofel@smartcontract.com> Date: Thu May 23 17:41:52 2024 +0200 [TT-1198] Fix missing logs (#13300) * dont fail with Failf(), use Errorf() instead; break loop when first concerning log is found * print test summary in automation nightly tests * remove unneeded file * do not add log stream clean up only when cleanup is set to none * fix VRFv2 smoke test * Fix log artifacts in github * TT-1198:fix TestVRFv2BatchFulfillmentEnabledDisabled test --------- Co-authored-by: lukaszcl <120112546+lukaszcl@users.noreply.github.com> Co-authored-by: Ilja Pavlovs <ilja.pavlovs@gmail.com> commit d90cd65 Author: Gabriel Paradiso <gabriel.paradiso@smartcontract.com> Date: Thu May 23 16:24:40 2024 +0200 [FUN-1332] Allowlist optimisation (#12588) * feat: update allowlist in batches giving priority to latest allowed addresses * fix: adjust iteration and add tests on updateAllowedSendersInBatches * fix: make a deep copy of the map to avoid race conditions * feat: extra step to fetch latest added addresses while batching * fix: check allowlist size is bigger than the batchsize * chore: remove leftover and add modify tests to be closer to a real scenario * chore: simplify lastBatchIdxStart * chore: remove newlines to pass sonarqube check commit 38a8f8d Author: Radek Scheibinger <scheibinger@users.noreply.github.com> Date: Thu May 23 16:00:37 2024 +0200 Bump crib chart and update config (#13238) * Bump crib chart and update config The latest version of crib chainlink chart uses map instead of array for defining nodes * Bump chart and update config commit 5db47b6 Author: krehermann <keith.rehermann@smartcontract.com> Date: Wed May 22 23:22:43 2024 -0600 KS-205: add workflow name to spec (#13265) * KS-205: add workflow name to spec * fix test * fix sql and test * fix tests * remove empty wf owner,name check * fix bad merge of main * rename migration --------- Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com> commit 1437410 Author: Cedric <cedric.cordenier@smartcontract.com> Date: Thu May 23 02:37:00 2024 +0100 Add ON DELETE CASCADE to workflow tables (#13165) commit 5a87f4a Author: Dylan Tinianov <dylantinianov@gmail.com> Date: Wed May 22 14:22:15 2024 -0400 Remove ClientErrors interface from common (#13279) * Move ClientErrors interface to common * Update blue-camels-promise.md * Remove client errors from common * Update blue-camels-promise.md * Delete clienterrors.go commit 6139126 Author: Awbrey Hughlett <awbrey.hughlett@smartcontract.com> Date: Wed May 22 12:54:24 2024 -0500 Pipeline Data Corruption (#13286) * Pipeline Data Corruption The unit test `TestDivide_Example` was acting flakey in the CI pipeline which suggested a flaw in the divide and multiply operations. When running the test, the expected result would be one of the input values or the division result in failure cases. This implied that results were either received out of order or were being sorted incorrectly. The pipeline runner does a final sort on the results, so that ruled out the received out of order possibility. On inspection of the sorting index on each task, every index was the zero value. This resulted in occasional correct and incorrect sorting, causing the test flake. To correct the problem, the test was updated such that the expected result has an index of `1`, leaving all other tasks with a `0` index. * fix test * updated changeset commit 087e2a7 Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Wed May 22 20:37:13 2024 +0300 VRF-1102: disable tests and checks depending on network type (Simulat… (#13290) * VRF-1102: disable tests and checks depending on network type (Simulated or live testnet) * VRF-1102: fixing tests commit eb6b50d Author: Bolek <1416262+bolekk@users.noreply.github.com> Date: Wed May 22 10:19:06 2024 -0700 EVM encoder support for tuples (#13202) credit goes to @archseer commit 677abe1 Author: Jordan Krage <jmank88@gmail.com> Date: Wed May 22 12:12:25 2024 -0500 golangci-lint: enable containedctx (#13171) commit 6625266 Author: Bartek Tofel <bartek.tofel@smartcontract.com> Date: Wed May 22 18:48:28 2024 +0200 do not set programmatically finality tag (#13277) Co-authored-by: Ilja Pavlovs <ilja.pavlovs@gmail.com> commit 6ff0ecd Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Wed May 22 19:42:04 2024 +0300 VRF-1054: VRF E2E tests - add additional way to catch rand fulfilment… (#13166) * VRF-1054: VRF E2E tests - add additional way to catch rand fulfilment event in case if chain is very fast * TT-1102: fixing fund return * VRF-1054: resolving conflicts commit a32c9ad Author: Lukasz <120112546+lukaszcl@users.noreply.github.com> Date: Wed May 22 17:11:38 2024 +0200 Update E2E tests pipeline to not fail during test coverage upload (#13276) commit 29b51c8 Author: Lukasz <120112546+lukaszcl@users.noreply.github.com> Date: Wed May 22 16:03:32 2024 +0200 Fix flushing log stream in tests (#13289) * Fix flushing log stream in tests * Refactor commit e728464 Author: Pablo Estrada <139084212+ecPablo@users.noreply.github.com> Date: Wed May 22 05:42:45 2024 -0600 fix: update docs in to endorse nix flakes as default usage for nix (#13085) * fix: add default to pkgs argument for nix shell. * fix: change docs to encourage default usage of nix flakes. * fix: small doc changes commit e247613 Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Wed May 22 11:02:17 2024 +0300 VRF-1100: Adjust test to use node toml for different chains (#13275) * VRF-1100: adding config for OPT Sepolia * VRF-1100: remove programmatic CL node setup for VRF from e2e tests * VRF-1100: add BASE sepolia config commit 322f3b9 Author: Dimitris Grigoriou <dimitris.grigoriou@smartcontract.com> Date: Tue May 21 23:09:47 2024 +0300 Decouple monitor tests from Core (#12995) * Add first version of evm utils * Remove unused context util * Add WSServer tests * Add NewLegacyTransaction test * Update NewTestChainScopedConfig to apply correct defaults * Move testutils * Decouple monitor tests from Core * Add changeset * Fix test case * Fix test case commit 921a015 Author: frank zhu <fr@nkzhu.com> Date: Tue May 21 12:18:01 2024 -0700 add CI changeset step to update jira issue with fixVersion (#13214) * add ci changeset step to update jira issue with fixVersion and labels based on tags * fix with for env * change core for testing * add changeset * add pnpm install and update working directory * fix * fix * fix env * remove test from core * update trigger condition * remove tags for now * rename * refactor * add test to core * reorder step * update changeset content * update log text * add private:true to package.json commit c14576a Author: krehermann <keith.rehermann@smartcontract.com> Date: Tue May 21 13:01:45 2024 -0600 KS-198: Workflow Spec Approval (#13181) * KS-198: Workflow Spec Approval * use job.Workflow spec, clarify code * add test for auto approval happy path * more tests * linter * better workflow spec validation * linter commit 4938ef3 Author: Bolek <1416262+bolekk@users.noreply.github.com> Date: Tue May 21 10:55:57 2024 -0700 [KS-196] ReportCodec implementation for Streams trigger (#13218) 1. Implement Codec, which validates report signatures and decodes needed fields. 2. Pass report context from Merucry Transmitter, which is needed to validate signatures. 3. Update fake Syncer to run successful e2e tests. commit a25ce4d Author: Lukasz <120112546+lukaszcl@users.noreply.github.com> Date: Tue May 21 19:27:56 2024 +0200 Update integration-tests workflow to continue-on-error when collect metrics step fail (#13278) commit 2cdd713 Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Tue May 21 12:23:14 2024 +0300 VRF-1096: Remove onlyOwner modifier from test consumers for when maki… (#13228) * VRF-1096: Remove onlyOwner modifier from test consumers for when making rand requests * Update gethwrappers * TT-1172: adding wrapper contract changes --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> commit 2644bd1 Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Tue May 21 11:27:01 2024 +0300 VRF-1098: Fix BHS Performance test after migrating to Seth (#13266) * VRF-1098: Fix BHS Performance test after migrating to Seth * VRF-1098: skip tests based on env variable * VRF-1098: retrieve blockhashtore address when using existing env * VRF-1098: minor refactoring * VRF-1098: big refactoring to make code more DRY commit 14ec6c4 Author: Lei <lei.shi@smartcontract.com> Date: Mon May 20 15:22:14 2024 -0700 make legacy URL optional for v03, make block number required for conditional using data streams (#13263) commit b00ad69 Author: Silas Lenihan <32529249+silaslenihan@users.noreply.github.com> Date: Mon May 20 16:48:47 2024 -0400 Update finality depth check headtracker (#13089) * Update finality depth check headtracker Signed-off-by: Silas Lenihan <sjl@lenihan.net> * added check for nil prevLatestFinalized * added changeset * updated changeset * cleaned up nil protection in LatestFinalizedHead * Added error tuple to LatestFinalizedHead * Added error tuple to LatestFinalizedHead * removed error from LatestFinalizedHead --------- Signed-off-by: Silas Lenihan <sjl@lenihan.net> commit dccbda7 Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Mon May 20 23:45:38 2024 +0300 TT-1102: fix return of the funds from CL node sending key (#13194) commit e48ed90 Author: Tate <tate.exon@smartcontract.com> Date: Mon May 20 13:37:53 2024 -0600 Run Keepers Tests On Merge Group Event (#13143) This was broken at some point and this fixes it commit 0d58a8d Author: Lei <lei.shi@smartcontract.com> Date: Mon May 20 12:11:09 2024 -0700 link transfer status (#13177) commit 5169bee Author: Bartek Tofel <bartek.tofel@smartcontract.com> Date: Mon May 20 19:05:57 2024 +0200 [TT-1187] Fix missing Loki log on CL node log scanner match (#13257) * save test summary & flush logs if log scanner detects failing logs; fix attaching log stream to evm nodes * fail in CI due to log scan * display error log only once, do not fail on purpose * use tagged CTF commit dfc399d Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Mon May 20 19:29:59 2024 +0300 VRF-1066: VRF e2e tests - parametrize waiting for 256 block timeout (#13197) * VRF-1066: VRF e2e tests - parametrize waiting for 256 block timeout * VRF-1066: minor changes commit 50569f7 Author: Lukasz <120112546+lukaszcl@users.noreply.github.com> Date: Mon May 20 18:11:43 2024 +0200 Add docs for setting node config in E2E tests (#13258) * Add docs for setting node config in E2E tests * Apply PR comments commit 0f29878 Author: Tate <tate.exon@smartcontract.com> Date: Mon May 20 09:48:41 2024 -0600 [TT-1164] Bump gotestloghelper version via common actions bump and in core ci (#13250) * Bump gotestloghelper version via common actions bump and in core * bump in make file as well commit 816d1ef Author: Ilja Pavlovs <ilja.pavlovs@gmail.com> Date: Mon May 20 18:06:51 2024 +0300 TT-1172: Add default Seth network setting values to default.toml (#13227) commit 6099abb Author: Iva Brajer <iva.brajer@smartcontract.com> Date: Mon May 20 16:52:32 2024 +0200 Added Base Sepolia to ChainUtils (#13216) * Added Base Sepolia to ChainUtils * Added tags to changeset files commit 5374a57 Author: krehermann <keith.rehermann@smartcontract.com> Date: Mon May 20 06:52:38 2024 -0600 KS-208 mv workflow yaml graph validation to chainlink-common (#13235) * prefactoring * update common ref commit 99e2a65 Author: Bartek Tofel <bartek.tofel@smartcontract.com> Date: Mon May 20 14:30:49 2024 +0200 [TT-1046] Add Chainlink node test config as TOML (#13142) * use latest Seth * move test config to CTF * use latest CTF that fixes eth2 genesis generation * use latest Seth * use tagged CTF version * WIP#1 * WIP#2 * add automation-specifc node configuration to TOML * add node TOML config for OCR forwarders smoke tests * add CL node TOML configuration for keeper tests * add CL node TOML config for log poller * add OCR1/2 TOML config * add VRF* CL node TOML config * remove functional options for setting CL node config in tests, use TOML instead * go mod tidy * fix go mod * fix test env builder * increase node funding in runlog test * increase vrf node funding * add on-demand keeper smoke tests workflow * run keeper smoke tests once * fix int tests yaml? * [TT-922, TT-943] Migrate automation and log poller tests to Seth (#12688) * WIP#1 * fix load test * lints * lints again * uncomment tests * fix logtrigger mercury test * set privilege before starting consumer * WIP#2 * WIP#2 - with high concurrency upkeep registration fails * more or less working * WIP#4 * small fixes * fix lints * use latest Seth * Migrated keeper benchmark, kind of * migrate keeper smoke tests * bunch of optimisation * migrate automation chaos test * migrate log poller tests to Seth * use anysynced key with log poller * fix some of failing smoke tests * fix go mod * use correct Seth version * better automation some test structure * better automation some test structure * go mod * fix issues with missing LINK funds * fix keeper test * fix automation test * clean up, comments, migrate keeper benchmark test * mend * use latest Seth * cleanups, comments, etc * clean ups, automation tests + keeper tests now always test multiple contracts * use newer action version * debug results when upkeeps fails * run automation tests with post-failure debug * run automation tests with post-failure debug * better staleness report * more debug for basic automation tests * more assertions * try with sleep * increase performance check timeout to 3m * separate config from consumer start * more debug for performance chcek * try with just 1 contract * one more clean up * run keeper tests in CI to test them * solve automation load test registration failures * subscribe to headers in benchmark test to observe upkeeps * centralised ephemeral keys on testnet check, fixed keeper smoke tests, added root key buffer check * do not fail, when on testnet and ephemeral keys are !=0, set them 0 instead * don't fail in test config, display warning if eph addresses are set and set them to 0 * fix possible nil pointer, remove block range timeout, mutex for error appending * update seth version * use buffered channel to read subscription headers from EVM node * benchmark test increase RR mem and set DEBUG log level * use CTF's concurrent executor to deploy contracts in parallel * change architecture so that we have only 1 subscription and then we fan out the header to all goroutines; use SafeEVMHeader * benchmark test increase geth disk and gaslimit * decrease log level, latest seth and ctf * update CTF dependency * use concurrent executor in automation load test * remove local replace * add header subscription reconnect handling * print return funds error * limit automation load test deployment concurrency * latest Seth + fix gun * do not run keeper smoke tests on each commit anymore * add one more error message * use tagged CTF * use latest Seth * use latest Seth * fix go.mod * forget about smart reconnect, just do it in a loop * use latest Seth * check if context has error before executing any of contract calling wrapper functions * prettify code + latest Seth * update Seth * optional retrying of read-only contract calls; used only by keeper benchmark test * update Seth, estimate gas for funds sending * fix new automation test, update Seth to v1.0.7 * increase timeout * fix max price smoke test * fix CreateOCRKeeperJobs for v2.0 * remove resolved TODO * code review changes * code review changes * code review changes vol 2 * use CTF release version * bump mod version --------- Co-authored-by: anirudhwarrier <12178754+anirudhwarrier@users.noreply.github.com> * fix issue introduced by merge conflict * adjust keeper & automation TOML configs * restore old integration-tests workflow that doesn't run keeper tests * fix double log stream shutdown * add back clNodeOpts * use tagged CTF version --------- Co-authored-by: Ilja Pavlovs <ilja.pavlovs@gmail.com> Co-authored-by: anirudhwarrier <12178754+anirudhwarrier@users.noreply.github.com> commit 14e5d11 Author: Bartek Tofel <bartek.tofel@smartcontract.com> Date: Mon May 20 14:19:36 2024 +0200 Ignore job removal critical error. Known issue with in-flight fix that's currently causing flakes (#13255) commit 0ecef68 Author: Bartek Tofel <bartek.tofel@smartcontract.com> Date: Mon May 20 13:35:34 2024 +0200 [TT-1179] scan cl logs to check plugin activation (#13247) * add support for median plugin in OCR2 tests * add support for median plugin in OCR2 tests * scan CL node logs to check whether plugins were activated * use tagged CTF version commit 53312f0 Author: Erik Burton <erikburt@users.noreply.github.com> Date: Fri May 17 13:45:38 2024 -0500 fix: always run solhint and prettier when changes exist (#13237) * fix: always run solhint and prettier when changes exist * chore: increase solhint max warnings to 2 commit 9f3efe6 Author: krehermann <keith.rehermann@smartcontract.com> Date: Fri May 17 12:11:16 2024 -0600 BCF-3236: skip divide example test to avoid CI flakes (#13249) commit 6f1ebca Author: Dmytro Haidashenko <34754799+dhaidashenko@users.noreply.github.com> Date: Fri May 17 19:58:06 2024 +0200 Fixed CPU usage issues caused by inefficiencies in HeadTracker (#13230) * Fixed CPU usage issues caused by inefficiencies in HeadTracker * added comments * revert heads back to the fix commit 03352fe Author: Bolek <1416262+bolekk@users.noreply.github.com> Date: Fri May 17 09:36:00 2024 -0700 Update Keystone types to latest common (#13248) 1. Package name change from "mercury" to "datastreams" 2. Simplify FeedReport signature fields commit 5f127d7 Author: Bartek Tofel <bartek.tofel@smartcontract.com> Date: Fri May 17 17:35:33 2024 +0200 only add grafana bearer token if it's not empty (#13224) # Conflicts: # core/capabilities/syncer.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng rand requests