Merged
Conversation
Merged
dimriou
changed the title
jmank88
reviewed
May 10, 2024
Comment on lines
+270
to
+271
| callback() | ||
| close(done) |
Contributor
There was a problem hiding this comment.
Pre-existing, but to avoid deadlockdelay until timeout in the case of a panicking callback():
Suggested change
| callback() | |
| close(done) | |
| defer close(done) | |
| callback() |
prashantkumar1982
previously approved these changes
May 11, 2024
jmank88
reviewed
May 20, 2024
jmank88
previously approved these changes
May 20, 2024
jmank88
approved these changes
May 20, 2024
|
amit-momin
approved these changes
May 21, 2024
This was referenced May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple monitor tests from Core.
Blocked by: