fix: max value is zero for some tokens #20096
Merged
+55
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
requested review from
vkjr,
J-Son89,
OmarBasem,
mmilad75 and
ulisesmac
briansztamfater
force-pushed
the
fix/token-max-value
branch
from
57d2158
to
f4c1f40
Compare
J-Son89
approved these changes
May 17, 2024
Jenkins BuildsClick to see older builds (21)
|
ulisesmac
approved these changes
May 17, 2024
briansztamfater
force-pushed
the
fix/token-max-value
branch
from
f4c1f40
to
ef1b7b0
Compare
90% of end-end tests have passedFailed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (47)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
briansztamfater
force-pushed
the
fix/token-max-value
branch
3 times, most recently
from
c13423c
to
f03aa65
Compare
|
Hi @briansztamfater! Could you please rebase the PR and resolve existing conflicts? Thank you! |
Yep, on it! @pavloburykh |
vkjr
reviewed
May 20, 2024
| :layer 1}]} | ||
| :wallet/current-viewing-account-tokens-filtered {:balances-per-chain {1 {:raw-balance | ||
| :wallet/wallet-send-token {:symbol :eth | ||
| :networks [{:source 879 |
There was a problem hiding this comment.
Looks like formatting needs one more run of make lint-fix)
vkjr
approved these changes
May 20, 2024
briansztamfater
force-pushed
the
fix/token-max-value
branch
2 times, most recently
from
91f4ecb
to
dbe4788
Compare
|
@pavloburykh rebase done |
briansztamfater
force-pushed
the
fix/token-max-value
branch
from
dbe4788
to
63ae0b0
Compare
87% of end-end tests have passedFailed tests (5)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
|
|
@briansztamfater thank you for the fixes. PR is ready for merge. |
Signed-off-by: Brian Sztamfater <brian@status.im>
briansztamfater
force-pushed
the
fix/token-max-value
branch
from
63ae0b0
to
6ed80ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19646
fixes #19813
fixes #19739
Summary
This PR fixes an issue where max value is 0 for some tokens and prevents it to send them
Platforms
Areas that maybe impacted
Functional
Steps to test
Case 1
Case 2
status: ready