New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moved cms components from DS to admin #20242
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but overall looks fine.
Whats your thoughts on the API surface? we're exporting 3/4 XXXXLayout components, would it better to just export an object of Layouts
? Should we be adding this to the Page
component we have instead? 🤔
packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx
Outdated
Show resolved
Hide resolved
packages/core/admin/admin/src/components/Layout/HeaderLayout.tsx
Outdated
Show resolved
Hide resolved
b249765
to
d50e43b
Compare
d50e43b
to
1832fb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do?
Why is it needed?
How to test it?
Related issue(s)/PR(s)