[Backport] Temporary directory under sql2 in lib and server #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuel-keller
changed the title
rushmorem
approved these changes
May 17, 2024
arriqaaq
reviewed
May 21, 2024
| @@ -4,7 +4,7 @@ version = "1.5.0" | |||
| edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| surrealdb = { path = "../../../lib", version = "1.5.0", features = ["kv-surrealkv", "sql2"] } | |||
| surrealdb = { path = "../../../lib", version = "1.5.0", features = ["kv-tikv"] } | |||
There was a problem hiding this comment.
Hey @emmanuel-keller
In 1.5, the surrealKV version is not updated because of which certain bugs which were seen before might still persist. Thought of informing in case you are testing anything out
There was a problem hiding this comment.
Just needs to be updated to this version as in on main
Line 146 in 5e33d4c
If required, I will open a PR on 1.5, please lemme know
There was a problem hiding this comment.
Indeed, as it is a different concern, it is better to make a separate PR
tobiemh
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
#4041
What does this change do?
Fixes the issue
What is your testing strategy?
Two micro test project linking with the lib (with and without
sql2) have been addedIs this related to any issues?
If this pull request is related to other pull requests, or resolves any issues, then link all related or closed items here.
Fixes #4041
Does this change need documentation?
Have you read the Contributing Guidelines?