-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Temporary directory under sql2 in lib and server #4050
Conversation
@@ -4,7 +4,7 @@ version = "1.5.0" | |||
edition = "2021" | |||
|
|||
[dependencies] | |||
surrealdb = { path = "../../../lib", version = "1.5.0", features = ["kv-surrealkv", "sql2"] } | |||
surrealdb = { path = "../../../lib", version = "1.5.0", features = ["kv-tikv"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @emmanuel-keller
In 1.5, the surrealKV version is not updated because of which certain bugs which were seen before might still persist. Thought of informing in case you are testing anything out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs to be updated to this version as in on main
Line 146 in 5e33d4c
surrealkv = { version = "0.1.5", optional = true } |
If required, I will open a PR on 1.5, please lemme know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, as it is a different concern, it is better to make a separate PR
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
#4041
What does this change do?
Fixes the issue
What is your testing strategy?
Two micro test project linking with the lib (with and without
sql2
) have been addedIs this related to any issues?
If this pull request is related to other pull requests, or resolves any issues, then link all related or closed items here.
Fixes #4041
Does this change need documentation?
Have you read the Contributing Guidelines?