Replace Guava Optional with Java Optional #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exoego
force-pushed
the
remove-guava-Optional
branch
2 times, most recently
from
b7d57f5
to
a6d19fd
Compare
exoego
force-pushed
the
remove-guava-Optional
branch
from
a6d19fd
to
e0c2c51
Compare
|
@exoego Thanks. We need to bump the major version for the next release. |
xerial
approved these changes
Jan 24, 2023
|
@yuokada Merging this to avoid Guava dependency hell. Let's release 1.0.0 with this update |
|
@xerial I will look in removing Guice |
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #135
I think #135 is going to introduce breaking change, since user needs replace Guava Optional in their code. Is this OK ? 馃