Fix: Tweak setupColumnSort() to fix exception when col no longer exists #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng column is in the sort list. Fixes #1015
ghiscoding
changed the title
|
@6pac The PR looks good, also for your info, you were mentioning that it's harder to debug JS code now, however you can do it directly in the editor now (VSCode). See animated gif below for how I do it now and feel free to ask any questions.
|
|
this fix is now ready to be pulled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak setupColumnSort() to fix exception when a no longer existing column is in the sort list.
Fixes #1015