Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General discussions, feedback, questions belong here (v5) #133

Closed
Aris-t2 opened this issue Jul 11, 2018 · 286 comments
Closed

General discussions, feedback, questions belong here (v5) #133

Aris-t2 opened this issue Jul 11, 2018 · 286 comments

Comments

@Aris-t2
Copy link
Owner

Aris-t2 commented Jul 11, 2018

Make sure you updated to the most recent version of this projects files "before" reporting problems!

Continued from #3, #41, #88 and #109.

Instead of opening new "issues" for general talk we can use this area for discussions, feedback and questions. Open new "issues" for real bugs and problems.

Custom JS scripts to restore more classic features
https://github.com/Aris-t2/CustomJSforFx

Trying to make CSS code ready for Firefox Quantum (57+)?
Remove all @namespace references. They are the reason, if your code refuses to work.

Application/hamburger button in tabs toolbar?
Look here: #46

Things this project will not target/recreate

  • curved tabs
  • old complete themes
  • ...

Things not possible with CSS

  • more toolbars like add-on/status bar (CSS can not create new toolbars)
    • displaying full sized status popup below window content is possible
    • moving bookmarks toolbar to windows bottom is possible
  • new buttons (CSS can not create new buttons)
  • additional menuitems (CSS can not create new items)
  • custom/new/different functions for buttons/menuitems/menus
  • activity indicator
  • preference/options window
  • additional location bar
  • favicon in location bars identity box
  • moving menubar items to a different toolbar
  • restart button
  • ... many more
@Achille-Grs
Copy link

Achille-Grs commented Jul 11, 2018

@Aris-t2 Hello! Can I ask if it is possible to place RSS feed in top of the menu bar?
51
? (see pic)

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 11, 2018

Move the "Subscribe" button into menubar when in customizing mode.

1

@Speravir
Copy link

Speravir commented Jul 11, 2018

I am not sure, but it seems there has been something changed for the overflow bar. I use overflow_menu_horizontal_remove_text.css, but have issues for some addons I’ve put there.

To follow: Put less than 14 addon symbols including the problematic ones into the overflow bar (with 14 it’s still visible, but less obvious). Install Containerise and ContextSearch. First check how it works with the symbols when they are set in default position in addonbar. Then move into overflow menu and check again.

And note also that with overflow_menu_remove_text.css no addon is usable anymore!

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 12, 2018

@Speravir
I think these two "options" did not work properly since the beginning, at least not for buttons with a sub view/menu. 1.9.8 fixes this problem: https://github.com/Aris-t2/CustomCSSforFx/releases

@nollinvoyd
Copy link

Hi Aris,

You put this together for me

/* NUMBERED TABS */ #tabbrowser-tabs{ counter-reset: n_tabs 0; } .tabbrowser-tab .tab-content { -moz-padding-start: 0px; } .tabbrowser-tab .tab-content::before { display: -moz-box; -moz-padding-end: 8px; counter-increment: n_tabs; content: counter(n_tabs); font-weight: bold !important; font-size: 16px !important; margin-top: -2px !important; }

In pre57, the numbered tabs addon extended to display in the All Tabs Helpe dropdown menu well as the default List All Tabs menu, which IMO was a great benefit. Neither occurs in quantum,.

Is there a possibility for this in quantum. Also, how about a scroll bar for the List All Tabs menu, or perhaps you suggest an addon that is better suited for the tasks I'm looking for.

@nollinvoyd
Copy link

nollinvoyd commented Jul 13, 2018

I've got these really handy buttons created with the custom buttons addon I was hoping you could fix.

Create Shortcut is a 2 way button that will either send a shortcut to the desktop without confrmation, or launches a popup for create a custom shortcut name
CREATE SHORTCUT.txt

Firefox toolbars zoom enlarges/shrinks the toolbars, text and icons proportionately
Firefox Toolbars Zoom.txt

thanks

@blackcrack
Copy link

it's maybe slowly possible for create a Gui to select and deselect maybe such as plugin "ClassicCustomationFFx" maybe can all these css-files compress with a 7z.dll into a 7zip-compressed file, therewith it's also possible to have the double amount of files into a single 7zip/library of the files as enable and disable via gui and this as plugin for ff .. to have the possible for copy/overwrite the css-files
by selecting/deselecting of an option (checkbox)
just only a idea/suggestion ..

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 14, 2018

@nollinvoyd

Edit: added code for Fx60-61.

The tab counter can be extended to alltabs popup:

/* Tab numbers */ 
#tabbrowser-tabs{ 
  counter-reset: n_tabs 0; 
}
.tabbrowser-tab .tab-content {
  -moz-padding-start: 0px; 
} 
.tabbrowser-tab .tab-content::before {
  display: -moz-box; 
  -moz-padding-end: 8px; 
  counter-increment: n_tabs; 
  content: counter(n_tabs); 
  font-weight: bold !important; 
  font-size: 16px !important; 
  margin-top: -2px !important; 
}

/* Tabs numbers in 'all tabs' popup */
#alltabs-popup, /*Fx60-61 */
#allTabsMenu-allTabsViewTabs { /*Fx62+ */
  counter-reset: nn_tabs 0; 
}

.alltabs-item::before, /*Fx60-61 */
.all-tabs-button::before { /*Fx62+ */
  display: -moz-box; 
  -moz-padding-end: 8px; 
  counter-increment: nn_tabs; 
  content: counter(nn_tabs); 
  font-weight: bold !important; 
  font-size: 16px !important; 
  margin-top: -2px !important; 
}

This shorter version should work too:

/* Tab numbers on tabs / Tabs numbers in 'all tabs' popup */ 
#tabbrowser-tabs,
#alltabs-popup, /*Fx60-61 */
#allTabsMenu-allTabsViewTabs { /*Fx62+ */ 
  counter-reset: n_tabs 0; 
}
.tabbrowser-tab .tab-content {
  -moz-padding-start: 0px; 
} 
.tabbrowser-tab .tab-content::before,
.alltabs-item::before, /*Fx60-61 */
.all-tabs-button::before { /*Fx62+ */
  display: -moz-box; 
  -moz-padding-end: 8px; 
  counter-increment: n_tabs; 
  content: counter(n_tabs); 
  font-weight: bold !important; 
  font-size: 16px !important; 
  margin-top: -2px !important; 
}

For the other request please read the first post of this discussion: -> Things not possible with CSS

@blackcrack
I have no plans to create a program/software to manage this projects features.
All files are offered as ".zip" inside "releases" area: https://github.com/Aris-t2/CustomCSSforFx/releases
I use "zip" for better cross platform/OS compatibility. Not everyone has 7Zip or Winrar or similar installed by default, but every OS can extract zip files by default.

@Speravir
Copy link

@blackcrack
Please, read my comment in issue #64.

@nollinvoyd
Copy link

Still no numbers on All Tabs Helper

@krystian3w
Copy link
Contributor

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 14, 2018

@nollinvoyd
I never said numbers would appear for that sidebar add-on. The extended code was for the default all tabs popup.

@nollinvoyd
Copy link

No numbers on "List all tabs" either.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 15, 2018

You are right, I previously tested on Fx63 and posted the code based on Fx63 without noticing Mozillas changes between Fx61 and Fx62. Now its fixed, use the updated code (above).

@nollinvoyd
Copy link

nollinvoyd commented Jul 15, 2018

That works. Thank you.

I assume it's not possible to do that for All Tabs Helper or something like it? I ask because the List All Tabs scroll is so painfully slow. Or maybe there's a way to speed it up?

Are we gonna have to revisit extra tweaks things like this for Fx 62?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 15, 2018

I can't offer support for "All Tabs Helper" add-on. Maybe its possible, maybe not. Try to contact the corresponding add-on dev.

Are we gonna have to revisit extra tweaks things like this for Fx 62?

It always was and will be like this. Mozilla changes something and add-on code or custom code has to be adjusted sooner or later. There is no guarantee everything will work forever.

@nollinvoyd
Copy link

nollinvoyd commented Jul 17, 2018

Decided to check out 62.0b8. I don't know if you want to bother with this because it's beta, but something in this code breaks the List All Tabs drop down menu. Works fine in Fx 61.0.1.

I tried, piece by piece, to isolate what was causing it, but the only thing that works is removing the whole thing.

/* From [TABS BELOW NAVIGATION AND BOOKMARKS TOOLBARS] conflicts with menu bar - 
https://github.com/Aris-t2/CustomCSSforFx/issues/132 */

/* don't show back or forward buttons if there's nothing to go back or forward to show */
#ctraddon_back-button[disabled="true"],
#ctraddon_forward-button[disabled="true"],
#back-button[disabled="true"],
#forward-button[disabled="true"] {
 display: none !important;
}

/* HIDE MIN/MAX/CLOSE BUTTONS - breaks tab bar narrowness*/

#titlebar-max,
#titlebar-close,
#titlebar-min,
#titlebar-buttonbox {
  min-width: 1px !important;
  width: 1px !important;
  max-width: 1px !important;
  opacity: 0 !important;
}

/* TAB BAR DECREASE HEIGHT AND CENTER TAB TEXT - ARIS */
/* CLOSE BUTTON ON THE LEFT - RED CLOSE BUTTON - NUMBERED TABS - ARIS */
/* tab height */
#tabbrowser-tabs,
#tabbrowser-tabs > .tabbrowser-arrowscrollbox,
.tabbrowser-tabs[positionpinnedtabs] > .tabbrowser-tab[pinned] {
  min-height: 19px !important;
  /*height: 19px !important;*/ /* this might be required for some OS themes */
}

#TabsToolbar #tabbrowser-tabs[overflow="true"] .tabbrowser-tab[pinned] {
  min-height: 18px !important;
  max-height: 18px !important;
}

#TabsToolbar .tabbrowser-tab {
  height: 19px !important;
  min-height: 19px !important;
  max-height: 19px !important;
}

/* tab label  */
.tab-label {
  -moz-box-flex: 1 !important;
  text-align: center !important;
  font-weight: bold !important;
  font-size: 16px !important;
  margin-top: -5px !important;
  -moz-margin-start: 0px !important;
  -moz-margin-end: 0px !important;
  -moz-padding-start: 0px !important;
  -moz-padding-end: 0px !important;
}

/* close icon */
#TabsToolbar #tabbrowser-tabs .tabbrowser-tab:not([pinned]) .tab-close-button {
  -moz-box-ordinal-group: 0 !important;
  -moz-margin-start: -9px !important;
  -moz-margin-end: 0px !important;
}

#main-window #navigator-toolbox #TabsToolbar .close-icon > .toolbarbutton-icon,
#main-window #navigator-toolbox #TabsToolbar .tab-content .close-icon  {
  min-width: 20px !important;
  width: 20px !important;
  min-height: 20px !important;
  height: 20px !important;
}

/* Tab numbers on tabs / Tabs numbers in 'all tabs' popup */ 
#tabbrowser-tabs,
#alltabs-popup, /*Fx60-61 */
#allTabsMenu-allTabsViewTabs { /*Fx62+ */ 
  counter-reset: n_tabs 0; 
}
.tabbrowser-tab .tab-content {
  -moz-padding-start: 0px; 
} 
.tabbrowser-tab .tab-content::before,
.alltabs-item::before, /*Fx60-61 */
.all-tabs-button::before { /*Fx62+ */
  display: -moz-box; 
  -moz-padding-end: 8px; 
  counter-increment: n_tabs; 
  content: counter(n_tabs); 
  font-weight: bold !important; 
  font-size: 16px !important; 
  margin-top: -2px !important; 
}

/* REMOVE EDIT MENU (IF YOU ALREADY USE ALL THE KEYBOARD SHORTCUTS) */
#edit-menu { display: none !important; }
#file-menu { display: none !important; }
#view-menu { display: none !important; }
#history-menu { display: none !important; }
#bookmarksMenu { display: none !important; }


/* Firefox userChrome.css - FOR EXITFIREFOXBUTTON_MOVABLE.UC.JS */

toolbarbutton#alltabs-button {
  -moz-binding: url("userChrome.xml#js");
}

#go-quit-application-button {
  list-style-image: url("exit.png") !important;
  -moz-image-region: rect(0px, 16px, 16px, 0px) !important;
}

/* Firefox userChrome.css - FOR OPEN PROFILE DIRECTORY BUTTON */

toolbarbutton#alltabs-button {
  -moz-binding: url("userChrome.xml#js");
}

#launch-profile-directory {
  list-style-image: url("launch.png") !important;
  -moz-image-region: rect(0px, 16px, 16px, 0px) !important;
}

/* fix tab toolbars button width/height for default tabs */

#navigator-toolbox #TabsToolbar .scrollbutton-up,
#navigator-toolbox #TabsToolbar .scrollbutton-down,
#navigator-toolbox #TabsToolbar #alltabs-button,
#navigator-toolbox #TabsToolbar #new-tab-button {
  padding: 0px !important;
}

#navigator-toolbox #TabsToolbar .scrollbutton-up > .toolbarbutton-icon,
#navigator-toolbox #TabsToolbar .scrollbutton-down > .toolbarbutton-icon,
#navigator-toolbox #TabsToolbar #alltabs-button > .toolbarbutton-icon,
#navigator-toolbox #TabsToolbar #new-tab-button > .toolbarbutton-icon,
#navigator-toolbox #TabsToolbar .tabs-newtab-button > .toolbarbutton-icon {
  padding: 0px !important;
  width: 16px !important;
  height: 16px !important;
}

/* hide empty space before and after tabs */
hbox[type="pre-tabs"],
hbox[type="post-tabs"] {
  min-width: 1px !important;
  width: 1px !important;
  max-width: 1px !important;
  opacity: 0 !important;
}


#main-window[tabsintitlebar][sizemode="normal"] #toolbar-menubar[autohide="true"][inactive="true"],
#main-window[tabsintitlebar][sizemode="maximized"] #toolbar-menubar[autohide="true"][inactive="true"] {
  margin-top: unset !important;
}

#main-window[tabsintitlebar] #toolbar-menubar[autohide="true"][inactive="true"] ~ #nav-bar:not(:-moz-lwtheme),
#main-window[tabsintitlebar] #toolbar-menubar[autohide="true"][inactive="true"] ~ #nav-bar {
  -moz-margin-end: 1px !important;
  -moz-appearance: none !important;  
  background: transparent !important;
  border-top: unset !important;
}

#main-window[sizemode="normal"] #navigator-toolbox #nav-bar {
  border-left: 0px !important;
  border-right: 0px !important;
}

#main-window[tabsintitlebar] #toolbar-menubar[autohide="true"][inactive="true"] ~ #nav-bar #nav-bar-customization-target {
  -moz-padding-start: 50px !important;
}

/* REMOVE LASTPASS FROM PAGE CONTEXT MENU */

menuitem[label="LastPass"] {
  display: none !important;
}

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 17, 2018

If "all tabs button" does not work properly, its obvious some code related to all tabs button causes the problem. In your case it is this code (and its present twice):

toolbarbutton#alltabs-button {
  -moz-binding: url("userChrome.xml#js");
}

Remove it and all tabs button/popup will work fine again.

Replace the above code with a button id you do not use, for example "character encoding" button, and place the button on a toolbar or this code will not work:

toolbarbutton#characterencoding-button {
  -moz-binding: url("userChrome.xml#js");
}
#main-window:not([customizing="true"]) toolbarbutton#characterencoding-button {
  visibility: collapse;
}

@nollinvoyd
Copy link

nollinvoyd commented Jul 17, 2018

ok, so I know you don't want to deal with buttons.

But by way of explanation, Morat has been so very kind to create a bunch of custom buttons for me. The one's referred to were the first two.

The code was was at least partially created because those buttons had separate images not included in the button code, exit.png & launch.png.

The 2 buttons in question have since been redone to include base64 for the images, but it did not dawn on me until I received your suggestions that the the references to exit.png & launch.png are no longer necessary. I removed those portions.

But I have limited understanding of what your suggestions have instructed me to do.

I know that originally

toolbarbutton#alltabs-button {
  -moz-binding: url("userChrome.xml#js");
}

Is needed to display the buttons. If I remove the code, the List All Tabs arrow menu works in Fx 62 beta, but all the buttons disappear, and no matter how I manipulate the replacement code you suggested, it doesn't seem to have a noticeable effect in either Firefox version, but, then again, I really don't know what I am doing.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 18, 2018

Look this project mainly deals with CSS and not with creating custom buttons. The code you got or shared appears to be from "Custom Buttons". There are multiple repositories dealing with creating buttons and I would appreciate you would ask there or the person created those buttons for you.

Please reread my previous post regarding all tabs button: #133 (comment)
I would not have suggested an alternative way to bind userChrome.xml to another button, if I had not tested and verified myself, that it is working on Fx 62 beta. Make sure you remove BOTH bindings of #alltabs-button from your code as it appears to by twice in there by mistake. The code I modified for you back then only contained one binding, no idea why you have added it a second time.

You can also try "method 2" from Scrollbars repository to add custom Javascripts to Firefox Quantum. It does not require rebinding any toolbar buttons for custom Javascripts to work.

@Pizzapops
Copy link

Pizzapops commented Jul 20, 2018

Compact Sidebar Menu
Using a clean profile in Nightly & the latest CCSS4Fx I have been trying to get as more compact SideBar header menu. Default theme, add-on bar on bottom & a few sidebar extensions added.
180720_sidemenu
my goal is a horizontal icon menu. (unfinished)
goal_sidemenu
It would be nice to switch from the pop-up menu to a static menu.
desired_sidemenu

/* compact sidebar menu */

/* Hide sepatators */
#widget-overflow-mainView > .panel-subview-body > toolbarseparator, 
.PanelUI-subView menuseparator, 
.PanelUI-subView toolbarseparator, 
.cui-widget-panelview menuseparator, 
.cui-widget-panel toolbarseparator {
    -moz-appearance: none;
    min-height: 0;
    border-top: 0px solid var(--panel-separator-color)!important;
    border-bottom: none;
    margin: 0px 0!important;
    padding: 0;
}

#sidebar {
    background-color: var(--sideBar-backgrnd-col) !important;
    min-width: 280px !important;
    max-width: none !important;
}
#sidebar-header { /* pretending to be a personal bar icon */
    margin-left: 0px !important;
    padding: 0px !important;
    border: none !important;
}

/* Hide search from bookmarks sidebar - optional*/
/* #sidebar-search-container { display: none !important; } */ 

#sidebar-switcher-target { /* recolour TST icon -not working?*/
    --webextension-menuitem-image: var(--tst-icon-loc-16) !important;
    --webextension-menuitem-image-2x: var(--tst-icon-loc-24) !important;
}

#sidebar-switcher-target :not(#sidebar-icon) { display: none; } /* hide sidebar switcher things except icon & keep close X*/
#sidebar-switcher-target
{
    margin-top: 2px !important;
    margin-bottom: -2px >!important;
    margin-left: 6px !important;
    padding: 2px !important;
    border-radius: 2px !important;
}
#sidebar-switcher-target:hover { background-color: var(--button-hover) !important; border-color: var(--button-hover) !important; }
#sidebar-switcher-target.active { background-color: var(--button-active) !important; border-color: var(--button-active) !important; }

/* popup menus */
/* sidebar menu */

#sidebarMenu-popup .panel-arrow { display: none !important; }
#sidebarMenu-popup toolbarbutton[checked] { display: none !important; }
/* #sidebarMenu-popup .toolbarbutton-text {  display: none !important; } */
#sidebarMenu-popup .subviewbutton[label="Close Sidebar"] {display: none !important; }
#sidebar-reverse-position{ display:none !important; }   /* Hide Move Sidebar to Right/Left */

#sidebarMenu-popup .panel-arrowcontent {
  margin-top: 1px !important;
  margin-left: 6px !important;
  background-color: #FFFFFF !important;
  border-color: var(--button-active) !important; }

/* display: grid;  NOT WORKING!*/
/*   grid-template-rows: 20px;/* one row */
/*   grid-template-columns: 33px 33px 33px 33px 33px 33px 33px 33px [col-end]; */
}

@krystian3w
Copy link
Contributor

krystian3w commented Jul 21, 2018

Please use Markdown code field with select CSS:

https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#code

```css


```

Becasue your code is broken - one line is italic, many single characters also, and nobody who cute github as normal formatting text.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 22, 2018

@Pizzapops
The menu looks like the one the old sidebar add-ons did provide. ;-)

CSS can not open/close popups, but a (Java)script, that catches the close command, could work.

@rayman89
Copy link

is there anything "big" planned for v2? @Aris-t2

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 24, 2018

I have no special plans for 2.0 of this project. The counter will just increase.

@rayman89
Copy link

Aww. Sad to hear that but still you do so much so thank you anyways.

BTW is there a way to add to the right click page menu under "this frame" the option to copy the frame url?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jul 25, 2018

Maybe, if "Someone™" would write an overlay (Java)script for the menu entry, a script to get the url and another script to copy url to clipboard, but why not simply use "Right-click > This Frame > View Frame Info" and copy the url from there?

@yurikhan
Copy link

Alternatively, Someone™ could write an extension that registers a context menu command, and when that command is clicked, copies the frame URL to the clipboard. I think all the necessary APIs are there.

@kanade96
Copy link

kanade96 commented Nov 2, 2018

Post your userChrome.css somewhere and link it here.

Here it is: https://mega.nz/#!WR4hXAgJ!FQDtG8Yk8BPXkAqTpsgsom4sBuWcqMQqg0cNYOyMSaM

@Achille-Grs
Copy link

Achille-Grs commented Nov 3, 2018

Hi @Aris-t2 Is possible to change the text align of "Update Date" in the addon page? (see pic)
1
Thank you!

@Crybal
Copy link

Crybal commented Nov 3, 2018

I ve placed some buttons on bookmarks toolbar but they seem...if fact they do not seem at all! How can I make the as in nav bar which are like a square-gray button (as a background) and the symbol od the add on inside?
Moreover,when I made buttons to have also labels ,every add on button disappeared!

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Nov 4, 2018

@Achille-Grs
It is no possible to align the date like that. If you disable "addonlists_show_addon_date_last_updated_start_position.css" again and use a custom right padding on the date item, you can move to the the left.

.addon .date-updated {
  -moz-padding-end: 100px !important;
}

@Crybal
Which buttons are you referring to and do these buttons have proper class attributes to be styled by general code?

It is possible some buttons do no offer button labels/text. In that case they can "disappears" in text modes.

Post before/after screenshots.

@TroudhuK
Copy link

TroudhuK commented Nov 4, 2018

image

Any idea about the different icon sizes?

In buttons_on_navbar_more_compact_mode.css I have changed:

/* more compact navigation toolbar */
#main-window[uidensity=compact] {
  --toolbarbutton-inner-padding: 3px !important; /* EDITED def: 5px */
}

/* fix for toolbar button badges */
#main-window[uidensity=compact] #nav-bar .toolbarbutton-1 .toolbarbutton-badge {
  -moz-margin-end: -3px !important; /* EDITED def: -5px */
  font-size: 8px !important; /* ADDED */
}

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Nov 4, 2018

How does everything look, if you don't change the code inside buttons_on_navbar_more_compact_mode.css?

Keep in mind those old icons have a fixed size and don't scale like svg icons of the add-ons you are using.

Edit
The old icon use own paddings. Changing such a general value affects all buttons and crushes the non-scaleable icons. Use default icons, if you want to use to above code.

Edit 2
Try to adjust icon sizes, maybe this helps (alter the '4'):

#nav-bar :-moz-any(#back-button,#forward-button,#home-button,#stop-button,#reload-button,/*#bookmarks-menu-button,*/#history-panelmenu,
	#add-ons-button,#open-file-button,#save-page-button,#sync-button,#feed-button,#characterencoding-button,#e10s-button,
	#new-window-button,#new-tab-button,#privatebrowsing-button,#find-button,#print-button,#fullscreen-button,#developer-button,
	#preferences-button,/*#PanelUI-menu-button,*/#cut-button,#copy-button,#paste-button,#zoom-out-button,#zoom-in-button,
	#tabview-button,#email-link-button,#sidebar-button,#web-apps-button,#webide-button,#developer-button,#containers-panelmenu,
	#library-button,#bookmarks-toolbar-placeholder,#nav-bar-overflow-button,#alltabs-button) .toolbarbutton-icon,
#nav-bar #bookmarks-menu-button > .toolbarbutton-icon,
#nav-bar :-moz-any(#panic-button,#pocket-button):not([open]) .toolbarbutton-icon {
  padding: 4px !important;
}

@TroudhuK
Copy link

TroudhuK commented Nov 4, 2018

With the original buttons_on_navbar_more_compact_mode.css:
image

My code, just commenting/disabling the --toolbarbutton-inner-padding set:
image
(good looking)

Your code (pasted in buttons_on_navbar_more_compact_mode.css) didn't change anything but I will do more tries.

So the problem is to keep the size of icons and only reduce the margin.

Edit: Ok, I make it work, thanks, I just need to add #main-window[uidensity=compact] before #nav-bar.

So my buttons_on_navbar_more_compact_mode.css is:

/* Firefox Quantum userChrome.css tweaks ************************************************/
/* Github: https://github.com/aris-t2/customcssforfx ************************************/
/****************************************************************************************/


/* more compact navigation toolbar */
#main-window[uidensity=compact] {
  --toolbarbutton-inner-padding: 3px !important; /* EDITED def: 5px */
}

/* ADDED */
#main-window[uidensity=compact] #nav-bar :-moz-any(#back-button,#forward-button,#home-button,#stop-button,#reload-button,#bookmarks-menu-button,#history-panelmenu,
	#add-ons-button,#open-file-button,#save-page-button,#sync-button,#feed-button,#characterencoding-button,#e10s-button,
	#new-window-button,#new-tab-button,#privatebrowsing-button,#find-button,#print-button,#fullscreen-button,#developer-button,
	#preferences-button,/*#PanelUI-menu-button,*/#cut-button,#copy-button,#paste-button,#zoom-out-button,#zoom-in-button,
	#tabview-button,#email-link-button,#sidebar-button,#web-apps-button,#webide-button,#developer-button,#containers-panelmenu,
	#library-button,#bookmarks-toolbar-placeholder,#nav-bar-overflow-button,#alltabs-button) .toolbarbutton-icon,
#main-window[uidensity=compact] #nav-bar :-moz-any(#panic-button,#pocket-button):not([open]) .toolbarbutton-icon {
  padding: 2px !important;
}

#main-window[uidensity=compact] #nav-bar #nav-bar-overflow-button,
#main-window[uidensity=compact] #nav-bar #nav-bar-customization-target > toolbarbutton,
#main-window[uidensity=compact] #nav-bar #nav-bar-customization-target > toolbaritem textbox,
#main-window[uidensity=compact] #nav-bar #nav-bar-customization-target #stop-reload-button > toolbarbutton {
  margin: 1px 0px !important;
  padding: 0 !important;
}

#main-window[uidensity=compact] #nav-bar #nav-bar-customization-target > toolbaritem {
  margin: 0 !important;
  padding: 0 !important;
}

/* fix for toolbar button badges */
#main-window[uidensity=compact] #nav-bar .toolbarbutton-1 .toolbarbutton-badge {
  -moz-margin-end: -3px !important; /* EDITED def: -5px */
  font-size: 8px !important; /* ADDED */
}

And the result is perfect for me:
image

@Crybal
Copy link

Crybal commented Nov 4, 2018

...
@Crybal
Which buttons are you referring to and do these buttons have proper class attributes to be styled by general code?

It is possible some buttons do no offer button labels/text. In that case they can "disappears" in text modes.

Post before/after screenshots.

all icons
lost icons

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Nov 5, 2018

@TroudhuK
Looks good!

@Crybal
Try fewer buttons. You have so many, that they get moved into "overflow" menu (>>) after enabling icons+text mode. That mode requires more horizontal space.

@Achille-Grs
Copy link

Hi @Aris-t2 Can you give tell me the code of this elements (see pic) to change the colors?
1

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Nov 5, 2018

@Achille-Grs
1, 3 and 4 are part of the html page this area uses. You can inspect it by right-clicking on it and selecting the area you are looking for.

2: https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/aboutaddons/addons_manager_alternative_appearance.css#L117

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Nov 6, 2018

Time to move to a new thread ;-)
#163

@Aris-t2 Aris-t2 closed this as completed Nov 6, 2018
@nollinvoyd
Copy link

nollinvoyd commented Nov 27, 2018

I have two requests that seem so obvious they must not be possible.

First, like in the old CTR, displaying the number (quantity) of addons on the addon page.

Second, can anything be done about the way these types of uselessly wide address buttons waste toolbar space.

Example:

address bar button

address bar button2

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Nov 27, 2018

First, like in the old CTR, displaying the number (quantity) of addons on the addon page.

CTR never could do that. You probably were using a different add-on for that.

Second, can anything be done about the way these types of uselessly wide address buttons waste toolbar space.

https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/locationbar/identitybox_labels_hidden.css

@nollinvoyd
Copy link

Thanks

@bendover22
Copy link

Aris - guten tag, mein Freund.
What's your suggestion if a user already has several custom rules in their own userChrome.css (unrelated to most from Aris' custom_css_for_Firefox files)?

  1. Does it matter if the users' own custom userChrome rules are put - before or after - Aris' custom rules in userChrome.css file? As long as there are no duplicated hacks?

I can't swear that none of my own custom rules will (or won't) need an xul or html @namespace line - only because I haven't tested them all extensively w/o any @namespace lines.

  1. If users only want 1 0r 2 of the custom *.css files from custom_css_for_fx_vx.x.x, is there a problem copying just those files (& any assoc. files from /chrome/config, or /chrome/image)? Of course, I think all extracted Custom_CSS files are only ~ 1.1 MB.

  2. Re: multi-row tabs. Are we supposed to use ONE tabs_multiple_lines.css files (v1 or v2)? If so, how to decide & why does v2 have an earlier date? The forum dialog for v2 is LONG & some info for v1 is in Japanese? It's really hard to believe Mozilla doesn't include multiple tab rows or they don't create an addon.

** I'll pass this along, in case you haven't seen it. It's not a userChrome hack, but some may find it useful, for now, if not attempting tabs multiple rows. If enough tabs are open to hide some off screen, you can press the meta key (Windows key) & scroll mouse wheel while hovering tabs, to scroll them back & forth. They move pretty fast. In Mint, the "Windows key" is shortcut to open Cinnamon menu (could change it).

Isn't the mentioned: "BUG: dragging tabs does not work properly with multi lined tabs" a deal breaker if you use / used dragging tabs & multi tab rows a lot?

@albino1
Copy link

albino1 commented Jan 12, 2019

@bendover22, use the JS multirow tabs from Aris-t2's CustomJSforFx repository, it's way more usable and allows tab dragging:

https://github.com/Aris-t2/CustomJSforFx

You can put your own rules wherever you want. Personally, I made my own @import lines with custom CSS files just so that it all made more sense in my head and the main userChrome.css didn't have a bunch of cluttered random code.

@bendover22
Copy link

Albino1 (sorta sounds politically incorrect :)
I'll check out the CustomJS.
So what you did was create a CSS file for your own codes, then added an @import line in Aris' userChrome.css file from Custom-CSS-for Fx?

If I understood, that sounds like a good way to keep your stuff separate. Easier to find, as well.
Especially if ever need to do troubleshooting - you can comment out a single @import line to disable your own code.

@albino1
Copy link

albino1 commented Jan 13, 2019

Yeah, at the bottom of the CustomCSSforFx file I just made my own section like this:

/* ~~~~~~~~~ MY OWN CUSTOM SCRIPTS FOR FIXING LITTLE THINGS ~~~~~~~~~ */
@import "./config/_albino1_custom_name_of_my_tweak_here.css"; /**/

And then obviously in the /config/ folder I put files called _albino1_custom_name_of_my_tweak_here.css or whatever, with my code in it.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jan 13, 2019

@bendover22
This thread already reached eol. ;-)

  1. It depends on how you are using the code. If you are using this project userChrome.css for example which already contains many @imports, your code would break it, if you place the raw code before the @imports. You can either place it at the bottom of the file or create and own CSS file you import with @import.

  2. You can just copy and paste the code you want to use into your file.

  3. There are different methods of implementations lead to different results. Just test both and decide which one you prefer. The date only indicates when the code was last modified.

If you need to drag&drop tabs, it is of course a deal breaker, but CSS has limitations. Read this thread and use the offered Javascript alternatives: #39

@albino1
My JS repository does not offer scripts for multiple tab rows. The scripts I modified to work with this projects files are in the corresponding thread: #39

Keep in mind, those scripts still use the same code this projects CSS files offer. The scripts only fix the darg&drop issue.

@albino1
Copy link

albino1 commented Jan 13, 2019

My JS repository does not offer scripts for multiple tab rows. The scripts I modified to work with this projects files are in the corresponding thread: #39

Ah, yeah, I actually forgot that you had posted those two custom scripts in that thread. And thank god you did, because it was a life saver :)

So @bendover22 ignore what I said earlier, and just pick whichever of the two versions you want from the post @Aris-t2 made here:

#39 (comment)

It's probably worth reading through the thread so you understand everything.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests