Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nixpkgs and add setuptools dependency to distlib #548

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Mar 28, 2023

This PR tried to upgrade nixpkgs to NixOS/nixpkgs@d6d8348, which is the parent commit of NixOS/nixpkgs@3e3c94b.

This PR did not upgrade nixpkgs to NixOS/nixpkgs@3e3c94b or a later revision, because NixOS/nixpkgs@3e3c94b upgraded packaging, introducing the breaking changes in pypa/packaging#530.

I also tried to upgrade nixpkgs to a newer revision in #547, which includes fixes to errors due to pypa/packaging#530.

@Atry Atry changed the title Update nixpkgs Update nixpkgs and add setuptools dependency to distlib Mar 28, 2023
@Atry
Copy link
Contributor Author

Atry commented Mar 28, 2023

I added setuptools to distlib in order to fix error ModuleNotFoundError: No module named 'setuptools', however, it seems the test stuck because of the fix:

https://github.com/DavHau/mach-nix/actions/runs/4539990576/jobs/8000410559?pr=548

@DavHau , do you have any idea about it?

@DavHau
Copy link
Owner

DavHau commented Mar 28, 2023

Timed out after 6h. Strange. I'll just run it again. Let's see

@Atry
Copy link
Contributor Author

Atry commented Apr 12, 2023

I think the timeout is due to upgrading nixpkgs, not because of adding setuptools. I split the setuptools part of this PR into #551, which passes CI.

@Atry Atry mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants