deprecate or remove deleteAttr? #846
Comments
This was referenced Apr 10, 2023
Merged
smjenness
added a commit
that referenced
this issue
May 4, 2023
smjenness
added a commit
that referenced
this issue
May 5, 2023
* netest update for compatibility with statnet/ergm@20c6c4c * removing networkLite tests that can go in lower level packages * add duration = 1 case to EpiModel networkLite tests * restore inadvertently removed skip_on_cran() * add ergm@master remote to ensure compatibility * try adding tergm@master as well * add ergm.ego@master remote to make basis available * specify basis = nw in netest, and remove one instance of nonsimp_update.formula references #806 * remove remaining uses of nonsimp_update.formula updating netest, trim_netest, and update_dissolution as needed also remove now-superfluous imports references #806 * remove unused ... * test updates for f56ce9a * additional non-nested EDA tests * update trimming behavior * remove redundant assignment * update required version numbers to current master values * #nolint variables whose use isn't recognized * roxygenize * add delete_edges references #837 * update trim_netest to allow keeping some objects references #836 * roxygenize * add tests for new (and old) update.R functionality * add trim_netest tests with keep argument * adjust duration check in simulate_dat references EpiModel/EpiModelHIV-p#250 * make duration checks consistent * add general purpose function to depart nodes from the dat object (#845) * add function to depart nodes from the dat object references #598 * add function for arriving new nodes to the dat object (#855) references #847 * deprecate deleteAttr (#854) * add function to depart nodes from the dat object references #598 * deprecate deleteAttr references #846 --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> * update depart_nodes docs for netsim_dat class (#856) * add function to depart nodes from the dat object references #598 * update docs for netsim_dat class --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> * update arrive_nodes docs for netsim_dat class (#857) * add function to depart nodes from the dat object references #598 * add function for arriving new nodes to the dat object references #847 * update docs for netsim_dat class --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> * Minor doc updates --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> Co-authored-by: Samuel Jenness <samuel.m.jenness@emory.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are no calls to
deleteAttrinEpiModel/EpiModel@depart_nodes,EpiModel/EpiModelHIV-p@depart_nodes,EpiModel/EpiModelCOVID@init_nets, orEpiModel/EpiModel-Gallery@multinets. Should we deprecate or removedeleteAttrfrom core EpiModel? As pointed out in #598 it is basically redundant withdelete_attr.The text was updated successfully, but these errors were encountered: