add general purpose function to depart nodes from the dat object #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2023
smjenness
added a commit
that referenced
this pull request
May 5, 2023
* netest update for compatibility with statnet/ergm@20c6c4c * removing networkLite tests that can go in lower level packages * add duration = 1 case to EpiModel networkLite tests * restore inadvertently removed skip_on_cran() * add ergm@master remote to ensure compatibility * try adding tergm@master as well * add ergm.ego@master remote to make basis available * specify basis = nw in netest, and remove one instance of nonsimp_update.formula references #806 * remove remaining uses of nonsimp_update.formula updating netest, trim_netest, and update_dissolution as needed also remove now-superfluous imports references #806 * remove unused ... * test updates for f56ce9a * additional non-nested EDA tests * update trimming behavior * remove redundant assignment * update required version numbers to current master values * #nolint variables whose use isn't recognized * roxygenize * add delete_edges references #837 * update trim_netest to allow keeping some objects references #836 * roxygenize * add tests for new (and old) update.R functionality * add trim_netest tests with keep argument * adjust duration check in simulate_dat references EpiModel/EpiModelHIV-p#250 * make duration checks consistent * add general purpose function to depart nodes from the dat object (#845) * add function to depart nodes from the dat object references #598 * add function for arriving new nodes to the dat object (#855) references #847 * deprecate deleteAttr (#854) * add function to depart nodes from the dat object references #598 * deprecate deleteAttr references #846 --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> * update depart_nodes docs for netsim_dat class (#856) * add function to depart nodes from the dat object references #598 * update docs for netsim_dat class --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> * update arrive_nodes docs for netsim_dat class (#857) * add function to depart nodes from the dat object references #598 * add function for arriving new nodes to the dat object references #847 * update docs for netsim_dat class --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> * Minor doc updates --------- Co-authored-by: Samuel Jenness <smjenness@gmail.com> Co-authored-by: Samuel Jenness <samuel.m.jenness@emory.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #598.
I called it
depart_nodesinstead ofdelete_nodesbecause in thenetworkDynamiccase you deactivate the nodes rather than actually deleting them from thenetworkDynamic(which is a different operation). We also have adelete_verticesfunction for edgelists, and I can imaginedelete_verticesanddelete_nodesgetting confused with each other.