Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow trim_netest to keep some variables in the formula environments #836

Closed
chad-klumb opened this issue Mar 20, 2023 · 0 comments · Fixed by #825
Closed

allow trim_netest to keep some variables in the formula environments #836

chad-klumb opened this issue Mar 20, 2023 · 0 comments · Fixed by #825

Comments

@chad-klumb
Copy link
Collaborator

Currently trim_netest does not retain any variables in most of the formula environments it trims. There are cases where the user would want to retain some variables in the formula environment, for example in using a variable cutoff or variable categories in the model or constraints formula, or passing some R object (e.g. a matrix) to terms/constraints that recognize it. Retaining e.g. a limited number of numerical parameters should not meaningfully affect memory usage but would significantly expand what can be conveniently expressed in these trimmed formulas. The default behavior of trim_netest can remain the same.

chad-klumb added a commit that referenced this issue Mar 21, 2023
@chad-klumb chad-klumb linked a pull request Apr 3, 2023 that will close this issue
smjenness added a commit that referenced this issue May 5, 2023
* netest update for compatibility with statnet/ergm@20c6c4c

* removing networkLite tests that can go in lower level packages

* add duration = 1 case to EpiModel networkLite tests

* restore inadvertently removed skip_on_cran()

* add ergm@master remote to ensure compatibility

* try adding tergm@master as well

* add ergm.ego@master remote to make basis available

* specify basis = nw in netest, and remove one instance of nonsimp_update.formula

references #806

* remove remaining uses of nonsimp_update.formula

updating netest, trim_netest, and update_dissolution as needed

also remove now-superfluous imports

references #806

* remove unused ...

* test updates for f56ce9a

* additional non-nested EDA tests

* update trimming behavior

* remove redundant assignment

* update required version numbers to current master values

* #nolint variables whose use isn't recognized

* roxygenize

* add delete_edges

references #837

* update trim_netest to allow keeping some objects

references #836

* roxygenize

* add tests for new (and old) update.R functionality

* add trim_netest tests with keep argument

* adjust duration check in simulate_dat

references EpiModel/EpiModelHIV-p#250

* make duration checks consistent

* add general purpose function to depart nodes from the dat object (#845)

* add function to depart nodes from the dat object

references #598

* add function for arriving new nodes to the dat object (#855)

references #847

* deprecate deleteAttr (#854)

* add function to depart nodes from the dat object

references #598

* deprecate deleteAttr

references #846

---------

Co-authored-by: Samuel Jenness <smjenness@gmail.com>

* update depart_nodes docs for netsim_dat class (#856)

* add function to depart nodes from the dat object

references #598

* update docs for netsim_dat class

---------

Co-authored-by: Samuel Jenness <smjenness@gmail.com>

* update arrive_nodes docs for netsim_dat class (#857)

* add function to depart nodes from the dat object

references #598

* add function for arriving new nodes to the dat object

references #847

* update docs for netsim_dat class

---------

Co-authored-by: Samuel Jenness <smjenness@gmail.com>

* Minor doc updates

---------

Co-authored-by: Samuel Jenness <smjenness@gmail.com>
Co-authored-by: Samuel Jenness <samuel.m.jenness@emory.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant