Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Uncaught TypeError: date.getDay is not a function in @d3fc/d3fc-discontinuous-scale/**/skipWeekends.js #2691

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Uncaught TypeError: date.getDay is not a function in @d3fc/d3fc-discontinuous-scale/**/skipWeekends.js #2691

wants to merge 2 commits into from

Commits on Jan 4, 2024

  1. Fix Uncaught TypeError: date.getDay is not a function in @d3fc/d3fc-d… 

    …iscontinuous-scale/**/skipWeekends.js

When combine VictoryVoronoiContainer with 
scaleDiscontinuous(
    d3Scale.scaleTime()
  ).discontinuityProvider(discontinuitySkipWeekends())

there would be an error: TypeError: date.getDay is not a function
when hovering the Chart
    @bl5ck
    bl5ck committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6b0a45f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from bl5ck/fix-x-data-is-not-a-date-instance 

    Fix Uncaught TypeError: date.getDay is not a function in @d3fc/d3fc-d…
    @bl5ck
    bl5ck committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    28f0d88 View commit details
    Browse the repository at this point in the history