Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Arch: Fixed regression in structures
- Loading branch information
1 parent
a16eec8
commit 01a7680
Showing
2 changed files
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01a7680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yorikvanhavre the proper tolerance value is 0.01? when I modified the functions in draftgeoutils I set the default value to -1 (ie 1e-7) which is perhaps too low. Is it preferable to have the default value of 0.01? If so, I could correct them all.
01a7680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marioalexis84 I think the Draft default is fine, because Draft deals with any kind of object, things modeled in microns, etc... However, Arch deals with architectural objects, where a tolerance of a hundredth of millimeter is more than enough.
This is exactly why it's a good idea to have a tolerance argument in that function, some contexts would want a specific case to return True while others False, depending on the scale of your work