Fix PartDesign::Mirrored #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extrema algorithm fails on touching (the manyfold detection fails to return a face, but several vertex, although a face is clearly touching and if bypassed the boolean succeeds), see https://www.freecadweb.org/tracker/view.php?id=3065 This commit enables the older boolean based intersection check.
…ous transformation executed
wwmayer
reviewed
Jun 15, 2017
| mtrx[0][0] = scale * m(1,1); | ||
| mtrx[0][1] = scale * m(1,2); | ||
| mtrx[0][2] = scale * m(1,3); | ||
| mtrx[0][0] = m(1,1); |
There was a problem hiding this comment.
Removing the scale factor here makes this function inconsistent for OCC < 7.0 and >= 7.0
So, what is the reason of removing it?
There was a problem hiding this comment.
Ah, ok. Thx for the pointer.
wwmayer
reviewed
Jun 15, 2017
| self.Doc.recompute() | ||
| self.failUnless(self.Mirrored.Shape.Volume < 2.0) | ||
| self.failUnless(self.Mirrored.Shape.Volume == 1.9999999999999993) |
There was a problem hiding this comment.
Exact comparison with floating numbers is a bad thing because it's simply too fragile. On my local system this unit test fails now. Also note that functions like failUnless are deprecated and should be replaced with their assert* equivalents.
In this case you should use assertAlmostEqual as described here https://docs.python.org/2/library/unittest.html
wwmayer
reviewed
Jun 15, 2017
| self.Mirrored.MirrorPlane = (self.Doc.XY_Plane, [""]) | ||
| self.Body.addObject(self.Mirrored) | ||
| self.Doc.recompute() | ||
| self.failUnless(self.Mirrored.Shape.Volume == 1.9999999999999993) |
|
Merged + correction added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one existsAnd please remember to update the Wiki with the features added or changed once this PR once it is merged.
Commits fix PartDesign::Mirrored behavior and add two unit tests for it. More detailed explanation available at https://kkremitzki.github.io/blog/gsoc-week-1-recap/