Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PartDesign::Mirrored #816

Closed
wants to merge 7 commits into from
Closed

Fix PartDesign::Mirrored #816

wants to merge 7 commits into from

Commits on Jun 12, 2017

  1. Reverting to checkIntersection via boolean operation 

    The extrema algorithm fails on touching (the manyfold detection fails to return a face, but several vertex, although a face is clearly touching and if bypassed the boolean succeeds), see
https://www.freecadweb.org/tracker/view.php?id=3065

This commit enables the older boolean based intersection check.
    @abdullahtahiriyo @kkremitzki
    abdullahtahiriyo authored and kkremitzki committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    6860dbe View commit details
    Browse the repository at this point in the history

  2. Fix transformation support, so that support is updated with any previ… 

    …ous transformation executed
    @abdullahtahiriyo @kkremitzki
    abdullahtahiriyo authored and kkremitzki committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    1d97222 View commit details
    Browse the repository at this point in the history

  3. Remove redundant matrix scale factor multiplication

    @kkremitzki
    kkremitzki committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    8e22e22 View commit details
    Browse the repository at this point in the history

  4. Show failure message when part design transformation does not intersect

    @kkremitzki
    kkremitzki committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    a52896e View commit details
    Browse the repository at this point in the history

  5. render both faces

    @abdullahtahiriyo @kkremitzki
    abdullahtahiriyo authored and kkremitzki committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    4455dc0 View commit details
    Browse the repository at this point in the history

  6. Add PartDesign_Mirrored offset failure test

    @kkremitzki
    kkremitzki committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    645ff35 View commit details
    Browse the repository at this point in the history

  7. Add PartDesign_Mirrored test based on additive primitive

    @kkremitzki
    kkremitzki committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    6e6326e View commit details
    Browse the repository at this point in the history