Boilerplate speedup #7654
Merged
Boilerplate speedup #7654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to land #7597 first. This will then need a rebase. |
|
+1. I'm generally a fan of using python over bash for this sort of thing. |
|
lgtm |
eparis
force-pushed
the
boilerplate-speedup
branch
from
8766166
to
3ea50cf
Compare
eparis
changed the title
|
Rebased. blocked on #7637 |
It's just a little bit faster..... BEFORE: $ time hack/verify-boilerplate.sh real 0m9.378s user 0m3.405s sys 0m13.906s AFTER: $ time hack/verify-boilerplate.sh real 0m0.181s user 0m0.114s sys 0m0.068s
eparis
force-pushed
the
boilerplate-speedup
branch
from
3ea50cf
to
f4d0b8d
Compare
j3ffml
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do all boilerplate checks in 1 python call. Calling python for every single file is slower than using the bash mess. But this is calling python 1 time and having the python process all of the files.
It's just a little bit faster.....